-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Upgrades UniFi Network Application to 8.6.9 #539
Conversation
Latest released version :https://www.ui.com/download/releases/network-server
WalkthroughThe pull request updates the Dockerfile for the UniFi software by changing the base image and upgrading the software version from 8.5.6 to 8.6.9. The Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
unifi/Dockerfile (2)
20-20
: Verify package authenticityConsider adding checksum verification for the downloaded package to ensure integrity.
&& curl -J -L -o /tmp/unifi.deb \ "https://dl.ui.com/unifi/8.6.9/unifi_sysvinit_all.deb" \ + && echo "expected-sha256sum /tmp/unifi.deb" | sha256sum --check \ && dpkg --install /tmp/unifi.deb \
20-20
: Consider documenting version update processTo help future maintainers, consider adding a comment with the official UniFi Network Server release page URL.
+# UniFi Network Server version (https://www.ui.com/download/unifi) && curl -J -L -o /tmp/unifi.deb \
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
unifi/Dockerfile
(1 hunks)
🔇 Additional comments (1)
unifi/Dockerfile (1)
20-20
: Verify the UniFi Network Server version compatibility
The upgrade from 8.5.6 to 8.6.9 appears to be a minor version bump. Please ensure:
- This version is compatible with the current base image (ubuntu-base:8.2.0)
- No breaking changes are introduced that could affect add-on functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @renewoensdregt 👍
../Frenck
Latest released version :https://www.ui.com/download/releases/network-server
Proposed Changes
Upgrading Dockerfile to take latest version of the released Unifi Network Server.
Related Issues
Summary by CodeRabbit