Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrades UniFi Network Application to 8.6.9 #539

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

renewoensdregt
Copy link
Contributor

@renewoensdregt renewoensdregt commented Nov 17, 2024

Latest released version :https://www.ui.com/download/releases/network-server

Proposed Changes

Upgrading Dockerfile to take latest version of the released Unifi Network Server.

Related Issues

(Github link to related issues or pull requests)

Summary by CodeRabbit

  • New Features
    • Updated to UniFi software version 8.6.9, enhancing performance and features.
  • Bug Fixes
    • Resolved issues related to the previous software version, improving stability.

Copy link

coderabbitai bot commented Nov 17, 2024

Walkthrough

The pull request updates the Dockerfile for the UniFi software by changing the base image and upgrading the software version from 8.5.6 to 8.6.9. The BUILD_FROM argument remains unchanged, while the URL for downloading the UniFi package has been modified to reflect the new version. Other aspects of the Dockerfile, such as system setup and health checks, are not affected by this change.

Changes

File Change Summary
unifi/Dockerfile Updated base image and UniFi software version from 8.5.6 to 8.6.9; modified download URL accordingly.

Possibly related PRs

Suggested labels

dependencies

Suggested reviewers

  • frenck

Poem

🐰 In the garden where changes bloom,
A new version brings a brighter room.
From eight point five to six we leap,
With Docker's dance, our code we keep.
Hops of joy, as updates flow,
UniFi's best, now watch it grow! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
unifi/Dockerfile (2)

20-20: Verify package authenticity

Consider adding checksum verification for the downloaded package to ensure integrity.

    && curl -J -L -o /tmp/unifi.deb \
        "https://dl.ui.com/unifi/8.6.9/unifi_sysvinit_all.deb" \
+   && echo "expected-sha256sum /tmp/unifi.deb" | sha256sum --check \
    && dpkg --install /tmp/unifi.deb \

20-20: Consider documenting version update process

To help future maintainers, consider adding a comment with the official UniFi Network Server release page URL.

+# UniFi Network Server version (https://www.ui.com/download/unifi)
    && curl -J -L -o /tmp/unifi.deb \
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 088c966 and eb5abd6.

📒 Files selected for processing (1)
  • unifi/Dockerfile (1 hunks)
🔇 Additional comments (1)
unifi/Dockerfile (1)

20-20: Verify the UniFi Network Server version compatibility

The upgrade from 8.5.6 to 8.6.9 appears to be a minor version bump. Please ensure:

  1. This version is compatible with the current base image (ubuntu-base:8.2.0)
  2. No breaking changes are introduced that could affect add-on functionality

@frenck frenck added dependencies Upgrade or downgrade of project dependencies. minor This PR causes a minor version bump in the version number. labels Nov 17, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @renewoensdregt 👍

../Frenck

@frenck frenck changed the title Bump Unifi Network Server to 8.6.9 ⬆️ Upgrades UniFi Network Server to 8.6.9 Nov 17, 2024
@frenck frenck changed the title ⬆️ Upgrades UniFi Network Server to 8.6.9 ⬆️ Upgrades UniFi Network Application to 8.6.9 Nov 17, 2024
@frenck frenck merged commit 55dfd2f into hassio-addons:main Nov 17, 2024
11 of 12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies. minor This PR causes a minor version bump in the version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants