Skip to content

Prevent ads rendering for apps interactive articles #15028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cemms1 merged 2 commits into from
Jan 22, 2026
+8 −6
Merged

Prevent ads rendering for apps interactive articles #15028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60fc819
remove AdPortals component from InteractiveLayout to avoid trying to …
cemms1 Dec 17, 2025
faf6c06
explicitly disable ads in apps interactives by preventing insertion o…
cemms1 Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions dotcom-rendering/src/layouts/InteractiveLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {
import { Hide } from '@guardian/source/react-components';
import { StraightLines } from '@guardian/source-development-kitchen/react-components';
import React from 'react';
import { AdPortals } from '../components/AdPortals.importable';
import { AdSlot, MobileStickyContainer } from '../components/AdSlot.web';
import { AppsFooter } from '../components/AppsFooter.importable';
import { ArticleBody } from '../components/ArticleBody';
Expand Down Expand Up @@ -313,11 +312,6 @@ export const InteractiveLayout = (props: WebProps | AppsProps) => {
</>
)}
<main data-layout="InteractiveLayout">
{isApps && renderAds && (
<Island priority="critical">
<AdPortals />
</Island>
)}
<Section
fullWidth={true}
showTopBorder={false}
Expand Down
8 changes: 8 additions & 0 deletions dotcom-rendering/src/model/enhance-ad-placeholders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,14 @@ export const enhanceAdPlaceholders =
(elements: FEElement[]): FEElement[] => {
if (shouldHideAds) return elements;

// Ads are intentionally disabled for apps interactive articles
if (
renderingTarget === 'Apps' &&
format.design === ArticleDesign.Interactive
) {
return elements;
}

// In galleries the AdPlaceholders are inserted in both
// Web & App because the same logic is used for both
if (format.design === ArticleDesign.Gallery) {
Expand Down
Loading