Prevent ads rendering for apps interactive articles #15028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days" |
|
This PR was closed because it has been stalled for 3 days with no activity. |
cemms1
force-pushed
the
cemms1/remove-adportals-for-interactive-articles
branch
from
a284118 to
d776e08
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
cemms1
added
the
maintenance
cemms1
force-pushed
the
cemms1/remove-adportals-for-interactive-articles
branch
from
d776e08 to
8c54475
Compare
…render ads in the app for these types of articles
cemms1
force-pushed
the
cemms1/remove-adportals-for-interactive-articles
branch
from
290ca6e to
faf6c06
Compare
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
AdPortalscomponent fromInteractiveLayout.AdPlaceholderElementsfrom being inserted into Apps Interactive articles (renderingTarget === 'Apps' && format.design === ArticleDesign.Interactive)This prevents ads from being inserted on apps for interactive articles.
Why?
The visuals team often have problems displaying ads on interactive articles in the apps.
In general, apps users tend to be premium users since the sign in gate prevents non premium users from viewing articles after a certain number of articles read. Ads are often disabled on these pieces in general and do not appear on web.
Preventing this happening is the most straightforward thing to do for now until we have a more robust solution