6th per claw mech #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… period's code, isn't currently following state system, nor is it using toggles; can fix in class
…tton release. Also now there are open and close constants for servos; they have placeholder values which we can replace after testing.
e3l
reviewed
Dec 3, 2021
| } | ||
| }; | ||
| tankSubsystem.setDefaultCommand(new RunCommand(tank, tankSubsystem)); | ||
| } |
There was a problem hiding this comment.
idk what happened but the indenting here got real funky.
vscode has auto formatting too: https://code.visualstudio.com/docs/cpp/cpp-ide#_code-formatting
| } | ||
|
|
||
| public void lowerClaw(){ | ||
| clawIsLifted = true; |
| } | ||
| } | ||
| else{ | ||
| if (clawIsOpen){ |
There was a problem hiding this comment.
you can do two separate if loops so you don't have to duplicate logic, one for lift and one for claw :)
| } | ||
|
|
||
| if(controlXbox2.getAButtonReleased()){ | ||
| if(clawSubsystem.clawIsOpen){ |
There was a problem hiding this comment.
just being picky -- could do clawSubsystem.clawIsOpen = !clawSubsystem.clawIsOpen
"use comments y'all" -Lucy Ma, 12/6/2021
|
Closed PR so we can delete this branch. Code has been moved to 2021ShopProj repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6th period claw mech w/ servos :)