Roller mech #2
Draft
Roller mech #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tonyxwu
requested review from
6kn4eakfr4s,
swaswa999,
siyoyoCode,
CrolineCrois and
eerinn
6kn4eakfr4s
reviewed
Nov 15, 2024
| @Override | ||
| public void periodic() { | ||
| // This method will be called once per scheduler run | ||
| rollerMotor.set(speed); |
There was a problem hiding this comment.
I would recommend writing a method to set the speed instead of putting it in periodic and set speed every time even when there's no new updates.
CrolineCrois
reviewed
Dec 3, 2024
| @@ -19,19 +23,20 @@ public class RobotContainer { | |||
|
|
|||
| // Controls defined | |||
| private final CommandPS4Controller mechController; | |||
| private final RollerSubsystem rollerSubsystem; | |||
| private final RollerCommands rollerCommand; | |||
CrolineCrois
reviewed
Dec 3, 2024
| speed = newSpeed; | ||
| } | ||
| /** | ||
| * An example method querying a boolean state of the subsystem (for example, a |
There was a problem hiding this comment.
update or delete the comments pls 😭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did the roller mech subsystem. Idk if it works or not but it seems correct but it just makes sense.