Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline initial #340

Open
wants to merge 36 commits into
base: ctan
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
8713c85
Interactions between 2-line initials and variable number of staff lines
rpspringuel Mar 16, 2020
d8829fc
Messed up initial test expectations
rpspringuel Mar 16, 2020
22939e1
Fixed initial position based on number of lines
rpspringuel Mar 16, 2020
1bb3555
Fix off-by one error
rpspringuel Mar 17, 2020
23d3667
Modify staff-line variant tests
rpspringuel Mar 17, 2020
9bac0d7
Accidentally introduced a stray line in this expectation
rpspringuel Mar 17, 2020
3f64a5e
Adjusting above-lines-text position
rpspringuel Mar 17, 2020
3939d17
Tests for initials taking up an arbitrary number of lines
rpspringuel Mar 18, 2020
f3b1755
Test for semi-manual multi-line initials
rpspringuel Mar 18, 2020
28702e0
Test setup for auto multi-line initials
rpspringuel Jun 16, 2020
2ced653
Merge branch 'ctan' into multiline_initial
rpspringuel Jun 17, 2020
f26c4cd
Merge branch 'ctan' into multiline_initial
rpspringuel Feb 7, 2021
da7a733
Revert "Test setup for auto multi-line initials"
rpspringuel Feb 7, 2021
e71a43a
Merge branch 'ctan' into multiline_initial
rpspringuel Feb 18, 2021
dee71fb
Updated expectations and add tests for unison line break change.
henryso May 24, 2021
a0c4d6d
Merge pull request #348 from henryso/develop
henryso Jul 10, 2021
f6de68e
Added test case from gregorio-project/gregorio#1538.
henryso Jul 13, 2021
ce0fbe5
Merge pull request #349 from henryso/fix-1538
henryso Jul 27, 2021
36a16b7
Added test from gregorio-project/gregorio#1551
henryso Jul 29, 2021
3a7039f
Merge pull request #350 from henryso/fix-1551
henryso Aug 3, 2021
c8b9db3
Added tests for virga fusion and shape hints.
henryso Feb 5, 2022
055a3af
Added missed tests.
henryso Feb 11, 2022
bc2a994
Merge pull request #351 from henryso/fix-1558
rpspringuel Feb 16, 2022
50b1a5e
Test illustrating the bug in #1373. Note that lualatex must be run tw…
davidweichiang Jan 20, 2025
9fad0e6
Results of PR https://github.com/gregorio-project/gregorio/pull/1605
davidweichiang Jan 20, 2025
c7f969c
Inconsequential visual change
rpspringuel Jan 21, 2025
aa65a17
Change some GNU-specific syntax to hopefully more portable syntax. No…
davidweichiang Jan 22, 2025
7f1ebbe
Merge pull request #356 from davidweichiang/escape_backslash
rpspringuel Jan 22, 2025
fdf5812
Merge commit '7f1ebbeb3035b9a401de461969263efb6a1ad52e' into develop
rpspringuel Jan 22, 2025
785fe4c
Test illustrating the bug in #1373. Note that lualatex must be run tw…
davidweichiang Jan 20, 2025
81a1606
Results of PR https://github.com/gregorio-project/gregorio/pull/1605
davidweichiang Jan 20, 2025
ff0c7fd
Merge branch 'fix-1373' of https://github.com/davidweichiang/gregorio…
davidweichiang Jan 22, 2025
ddd5f58
Widen fix-1373 to avoid bug https://github.com/gregorio-project/grego…
davidweichiang Jan 22, 2025
adbdf91
Widen fix-1373 to avoid bug https://github.com/gregorio-project/grego…
davidweichiang Jan 22, 2025
4d36f84
Merge pull request #352 from davidweichiang/fix-1373
rpspringuel Jan 23, 2025
9ed68ea
Merge branch 'develop' into multiline_initial
rpspringuel Jan 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gregorio-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ test|retest)
overall_result=0
time for group in ${groups}
do
if ! ${group}_find | filter | $XARGS -0 -P $NPROCESSORS -n 1 -I{} bash -c "${group}_test"' "$@"' _ {} \;
if ! ${group}_find | filter | $XARGS -0 -P $NPROCESSORS -I{} bash -c "${group}_test"' "$@"' _ {} \;
then
overall_result=1
fi
Expand Down
40 changes: 20 additions & 20 deletions harness.sh
Original file line number Diff line number Diff line change
Expand Up @@ -268,16 +268,16 @@ function gabc_gtex_test {
then
fail "Did not fail" "$filename should have failed"
else
${SED} -e 's/^\(% File generated by gregorio \).*/\1@/' \
-e 's/\(\GregorioTeXAPIVersion{\)[^}]\+/\1@/' \
-e 's/\(\GreBeginScore{\)[^}]\+/\1@/' \
${SED} -E -e 's/^(% File generated by gregorio ).*/\1@/' \
-e 's/(\\GregorioTeXAPIVersion\{)[^}]+/\1@/' \
-e 's/(\\GreBeginScore\{)[^}]+/\1@/' \
"$outfile" > "$outfile-"
if [ -f "$expfile" ]
then
$verify "$filename" && ${SED} \
-e 's/^\(% File generated by gregorio \).*/\1@/' \
-e 's/\(\GregorioTeXAPIVersion{\)[^}]\+/\1@/' \
-e 's/\(\GreBeginScore{\)[^}]\+/\1@/' \
$verify "$filename" && ${SED} -E \
-e 's/^(% File generated by gregorio ).*/\1@/' \
-e 's/(\\GregorioTeXAPIVersion\{)[^}]+/\1@/' \
-e 's/(\\GreBeginScore\{)[^}]+/\1@/' \
"$expfile" > "$expfile-"
maybe_run "$filename" diff -q "$outfile-" "$expfile-"
else
Expand Down Expand Up @@ -346,12 +346,12 @@ function gabc_dump_test {
then
fail "Did not fail" "$filename should have failed"
else
${SED} -e 's/[0-9]\+\( (\(GRE\|S\|G\|L\|SP\|\)_\)/@\1/' "$outfile" \
${SED} -E -e 's/[0-9]*( \((GRE_|S_|G_|L_|SP_|_))/@\1/' "$outfile" \
> "$outfile-"
if [ -f "$expfile" ]
then
$verify "$filename" && ${SED} \
-e 's/[0-9]\+\( (\(GRE\|S\|G\|L\|SP\|\)_\)/@\1/' "$expfile" \
$verify "$filename" && ${SED} -E \
-e 's/[0-9]*( \((GRE_|S_|G_|L_|SP_|_))/@\1/' "$expfile" \
> "$expfile-"
maybe_run "$filename" diff -q "$outfile-" "$expfile-"
else
Expand Down Expand Up @@ -420,18 +420,18 @@ function gabc_gabc_test {
then
fail "Did not fail" "$filename should have failed"
else
${SED} -e 's/^\(% File generated by gregorio \).*/\1@/' \
-e 's/^\(generated-by: \).*;$/\1@;/' \
-e 's/^\(\GregorioTeXAPIVersion{\)[^}]*/\1@/' \
-e 's/^\(\GreBeginScore{\)[^}]*/\1@/' "$outfile" \
${SED} -E -e 's/^(% File generated by gregorio ).*/\1@/' \
-e 's/^(generated-by: ).*;$/\1@;/' \
-e 's/^(\\GregorioTeXAPIVersion\{)[^}]*/\1@/' \
-e 's/^(\\GreBeginScore\{)[^}]*/\1@/' "$outfile" \
> "$outfile-"
if [ -f "$expfile" ]
then
$verify "$filename" && ${SED} \
-e 's/^\(% File generated by gregorio \).*/\1@/' \
-e 's/^\(generated-by: \).*;$/\1@;/' \
-e 's/^\(\GregorioTeXAPIVersion{\)[^}]*/\1@/' \
-e 's/^\(\GreBeginScore{\)[^}]*/\1@/' "$expfile" \
$verify "$filename" && ${SED} -E \
-e 's/^(% File generated by gregorio ).*/\1@/' \
-e 's/^(generated-by: ).*;$/\1@;/' \
-e 's/^(\\GregorioTeXAPIVersion\{)[^}]*/\1@/' \
-e 's/^(\\GreBeginScore\{)[^}]*/\1@/' "$expfile" \
> "$expfile-"
maybe_run "$filename" diff -q "$outfile-" "$expfile-"
else
Expand Down Expand Up @@ -528,7 +528,7 @@ function typeset_and_compare {
pdffile="$filebase.pdf"
cmdoutfile="$filebase.cmdout"

if "$@" --output-directory="$outdir" "$texfile" >&"$outdir"/"$cmdoutfile"
if "$@" --output-directory="$outdir" "$texfile" >"$outdir"/"$cmdoutfile" 2>&1
then
if [[ "$indir/" == */should-fail/* ]]
then
Expand Down
4 changes: 3 additions & 1 deletion tests/gabc-dump/5-lines.dump
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,9 @@
character e
---------------------------------------------------------------------
end of style ST_CENTER
---------------------------------------------------------------------

Abovelinestext
above lines text---------------------------------------------------------------------
type 3 (GRE_ELEMENT)
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
type 2 (GRE_GLYPH)
Expand Down
111 changes: 111 additions & 0 deletions tests/gabc-dump/bugs/fix-1538.dump
Original file line number Diff line number Diff line change
@@ -0,0 +1,111 @@
=====================================================================
SCORE INFOS
=====================================================================
number_of_voices 1
name March 30 sample


=====================================================================
HEADERS
=====================================================================
name March 30 sample


=====================================================================
VOICES INFOS
=====================================================================
Voice 1
initial_key 5 (c3)


=====================================================================
SCORE
=====================================================================
type 0 (GRE_SYLLABLE)
position 2 (WORD_MIDDLE)
---------------------------------------------------------------------
character F
---------------------------------------------------------------------
character o
---------------------------------------------------------------------
character r
---------------------------------------------------------------------
type 3 (GRE_ELEMENT)
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
type 2 (GRE_GLYPH)
glyph_type 15 (G_PUNCTUM)
- - - - - - - - - - - - - - - - - - - - - - -
type 1 (GRE_NOTE)
pitch h
shape 1 (S_PUNCTUM)
=====================================================================
type 0 (GRE_SYLLABLE)
position 2 (WORD_MIDDLE)
---------------------------------------------------------------------
beginning of style ST_FIRST_WORD
---------------------------------------------------------------------
character -
---------------------------------------------------------------------
end of style ST_FIRST_WORD
---------------------------------------------------------------------
beginning of style ST_CENTER
---------------------------------------------------------------------
beginning of style ST_FIRST_WORD
---------------------------------------------------------------------
beginning of style ST_ITALIC
---------------------------------------------------------------------
character e
---------------------------------------------------------------------
end of style ST_ITALIC
---------------------------------------------------------------------
end of style ST_FIRST_WORD
---------------------------------------------------------------------
end of style ST_CENTER
---------------------------------------------------------------------
beginning of style ST_FIRST_WORD
---------------------------------------------------------------------
beginning of style ST_ITALIC
---------------------------------------------------------------------
character v
---------------------------------------------------------------------
end of style ST_ITALIC
---------------------------------------------------------------------
end of style ST_FIRST_WORD
---------------------------------------------------------------------
type 3 (GRE_ELEMENT)
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
type 2 (GRE_GLYPH)
glyph_type 15 (G_PUNCTUM)
- - - - - - - - - - - - - - - - - - - - - - -
type 1 (GRE_NOTE)
pitch h
shape 1 (S_PUNCTUM)
=====================================================================
type 0 (GRE_SYLLABLE)
position 3 (WORD_END)
---------------------------------------------------------------------
beginning of style ST_CENTER
---------------------------------------------------------------------
beginning of style ST_FIRST_WORD
---------------------------------------------------------------------
character e
---------------------------------------------------------------------
end of style ST_FIRST_WORD
---------------------------------------------------------------------
end of style ST_CENTER
---------------------------------------------------------------------
beginning of style ST_FIRST_WORD
---------------------------------------------------------------------
character r
---------------------------------------------------------------------
end of style ST_FIRST_WORD
---------------------------------------------------------------------
type 3 (GRE_ELEMENT)
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
type 2 (GRE_GLYPH)
glyph_type 15 (G_PUNCTUM)
- - - - - - - - - - - - - - - - - - - - - - -
type 1 (GRE_NOTE)
pitch h
shape 1 (S_PUNCTUM)
=====================================================================
3 changes: 3 additions & 0 deletions tests/gabc-dump/bugs/fix-1538.gabc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
name: March 30 sample;
%%
(c3)For(h)-<i>ev</i>(h)er(h)
Binary file modified tests/gabc-dump/glyphs/above_lines_text.pdf
Binary file not shown.
Loading