Multiline initial #340
Open
Multiline initial #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a test to show how 2-line initials behave with staves that have 2, 3, or 5 lines (4 is also shown for comparison) Note that initial's baseline does not align with lyrics for these cases
Committed wrong version of one test expectation (from before the test was finalized) and forgot another The 2-line-initials expectation is still a wrong expectation
Found a fault in the way that the above line text is placed. As with the large initial, the placement is always calculated as if the staff had four lines. These modified tests make the problem visible.
Corresponds to changes in gregorio-project/gregorio@522774a
No expectation yet as the implementation doesn't work yet.
This reverts commit 28702e0.
|
I've stripped out the tests for automatic multi-line initials because that appears to require a wholesale rewrite of how lines are drawn and won't be ready for the next release. |
Updated expectations and add tests for unison line break change.
Fixed xargs warning that -n and -I are mutually exclusive. Tests gregorio-project/gregorio#1538
Added test case from gregorio-project/gregorio#1538.
Tests the implementation of gregorio-project/gregorio#1558.
Added tests for virga fusion and shape hints.
…ice for the bug to appear; for this reason, fix-1373.gaux is included in the commit.
…w works on MacOS (BSD sed and zsh).
…ckslash Make harness.sh more portable
…ice for the bug to appear; for this reason, fix-1373.gaux is included in the commit.
…it illustrates the fix of bug gregorio-project/gregorio#1373 using gregorio-project/gregorio#1605
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with gregorio-project/gregorio#1491