feat(compiler): Use data segments for string data #1330
+107
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
force-pushed
the
oscar/data-segments
branch
from
d6820a9 to
bbdd61c
Compare
ospencer
force-pushed
the
oscar/data-segments
branch
from
bbdd61c to
6e68d1b
Compare
ospencer
commented
Sep 30, 2023
ospencer
force-pushed
the
oscar/data-segments
branch
from
6e68d1b to
032d567
Compare
ospencer
requested review from
jozanza,
marcusroberts,
peblair and
phated
as code owners
spotandjake
approved these changes
Jan 31, 2024
Member
spotandjake
left a comment
spotandjake
left a comment
There was a problem hiding this comment.
I really like how much cleaner the outputted code is with this change.
Member
|
I am pretty sure this was unblocked with #2104 as we no longer lose the debug information when linking. |
ospencer
force-pushed
the
oscar/data-segments
branch
from
cf70d3b to
68b9ed5
Compare
ospencer
force-pushed
the
oscar/data-segments
branch
2 times, most recently
from
e90cc27 to
15a2620
Compare
Member
Author
|
Rebased this. Looks like it's largely working with one test failure that needs to be looked into. I also don't like how the data segments are handled; they're lumped in with the type metadata. That'll need to be cleaned up. |
ospencer
force-pushed
the
oscar/data-segments
branch
from
15a2620 to
8c062af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.