Skip to content

impl(v3): add grpc ports includes for windows portability #15923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scotthart merged 8 commits into from
Jan 30, 2026
+22,258 −14
Merged

impl(v3): add grpc ports includes for windows portability #15923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
59c1d78
impl(v3): add grpc ports includes for windows portability
scotthart Jan 30, 2026
ce1ef8a
generate code
scotthart Jan 30, 2026
66e12b2
update storage files
scotthart Jan 30, 2026
1520a37
use our copies of ports files
scotthart Jan 30, 2026
ab5336f
create copies of grpc ports files so they are always available
scotthart Jan 30, 2026
043f8cd
update storage files again
scotthart Jan 30, 2026
1888442
regenerated code
scotthart Jan 30, 2026
af0ecc5
formatting
scotthart Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
3 changes: 3 additions & 0 deletions .typos.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ extend-exclude = [
"external/googleapis.patch",
# Mispelled test names in Bigtable conformance tests
"google/cloud/bigtable/ci/run_conformance_tests_proxy_bazel.sh",
# ports files don't need to be checked
"google/cloud/ports_def.inc",
"google/cloud/ports_undef.inc",
]

[default]
Expand Down
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/deprecated_auth_decorator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@
#include <memory>
#include <utility>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand All @@ -44,3 +47,5 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace golden_v1_internal
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/deprecated_auth_decorator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
#include <set>
#include <string>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -53,4 +56,6 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"

#endif // GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_V1_INTERNAL_DEPRECATED_AUTH_DECORATOR_H
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/deprecated_logging_decorator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
#include <string>
#include <utility>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -55,3 +58,5 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace golden_v1_internal
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/deprecated_logging_decorator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
#include <set>
#include <string>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -53,4 +56,6 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"

#endif // GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_V1_INTERNAL_DEPRECATED_LOGGING_DECORATOR_H
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/deprecated_metadata_decorator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
#include <utility>
#include <vector>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -71,3 +74,5 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace golden_v1_internal
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/deprecated_metadata_decorator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
#include <memory>
#include <string>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -60,4 +63,6 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"

#endif // GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_V1_INTERNAL_DEPRECATED_METADATA_DECORATOR_H
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/deprecated_stub.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
#include <memory>
#include <utility>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand All @@ -47,3 +50,5 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace golden_v1_internal
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/deprecated_stub.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
#include <memory>
#include <utility>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -61,4 +64,6 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"

#endif // GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_V1_INTERNAL_DEPRECATED_STUB_H
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/deprecated_stub_factory.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
#include <memory>
#include <utility>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -71,3 +74,5 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace golden_v1_internal
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/deprecated_stub_factory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
#include "google/cloud/version.h"
#include <memory>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand All @@ -39,4 +42,6 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"

#endif // GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_V1_INTERNAL_DEPRECATED_STUB_FACTORY_H
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/deprecated_tracing_stub.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@
#include <memory>
#include <utility>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -50,3 +53,5 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace golden_v1_internal
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/deprecated_tracing_stub.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
#include "google/cloud/version.h"
#include <memory>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -60,4 +63,6 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"

#endif // GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_V1_INTERNAL_DEPRECATED_TRACING_STUB_H
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/golden_kitchen_sink_auth_decorator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
#include <memory>
#include <utility>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -225,3 +228,5 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace golden_v1_internal
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/golden_kitchen_sink_auth_decorator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
#include <set>
#include <string>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -144,4 +147,6 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"

#endif // GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_V1_INTERNAL_GOLDEN_KITCHEN_SINK_AUTH_DECORATOR_H
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/golden_kitchen_sink_logging_decorator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@
#include <string>
#include <utility>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -323,3 +326,5 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace golden_v1_internal
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/golden_kitchen_sink_logging_decorator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
#include <set>
#include <string>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -145,4 +148,6 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"

#endif // GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_V1_INTERNAL_GOLDEN_KITCHEN_SINK_LOGGING_DECORATOR_H
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/golden_kitchen_sink_metadata_decorator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@
#include <utility>
#include <vector>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -284,3 +287,5 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace golden_v1_internal
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/golden_kitchen_sink_metadata_decorator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
#include <memory>
#include <string>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -151,4 +154,6 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"

#endif // GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_V1_INTERNAL_GOLDEN_KITCHEN_SINK_METADATA_DECORATOR_H
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/golden_kitchen_sink_round_robin_decorator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@
#include <mutex>
#include <vector>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -176,3 +179,5 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace golden_v1_internal
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/golden_kitchen_sink_round_robin_decorator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
#include <mutex>
#include <vector>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -145,4 +148,6 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"

#endif // GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_V1_INTERNAL_GOLDEN_KITCHEN_SINK_ROUND_ROBIN_DECORATOR_H
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/golden_kitchen_sink_stub.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
#include <memory>
#include <utility>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -259,3 +262,5 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace golden_v1_internal
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/golden_kitchen_sink_stub.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@
#include <memory>
#include <utility>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -266,4 +269,6 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"

#endif // GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_V1_INTERNAL_GOLDEN_KITCHEN_SINK_STUB_H
5 changes: 5 additions & 0 deletions generator/integration_tests/golden/v1/internal/golden_kitchen_sink_stub_factory.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@
#include <memory>
#include <utility>

// Must be included last.
#include "google/cloud/ports_def.inc"

namespace google {
namespace cloud {
namespace golden_v1_internal {
Expand Down Expand Up @@ -77,3 +80,5 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace golden_v1_internal
} // namespace cloud
} // namespace google

#include "google/cloud/ports_undef.inc"
Loading
Loading