impl(v3): add grpc ports includes for windows portability

[scotthart]

Update: I had hoped to just include grpcpp/ports_*def.inc but those headers are not always installed, so I had to add similar *.inc files to google/cloud/.

storage protos contain a method called GetObject. windows.h contains preprocessor macros that change all instances of GetObject to GetObjectA. protobuf and grpc have existing mechanisms to work around this macro. Previously we benefited from grpc's mechanism without needing to do anything ourselves, but that has changed. This PR leverages grpc's ports_def.inc and ports_undef.inc to restore that mechanism to our code.

[gemini-code-assist]

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a specific compilation issue encountered on Windows platforms where the GetObject method in certain protobuf definitions clashes with a macro defined in windows.h. By strategically including gRPC's port definition and undefinition headers, the generated C++ client libraries now correctly handle these name conflicts, ensuring broader cross-platform compatibility without requiring manual intervention in generated files.

Highlights

• Windows Portability Fix: Ensured cross-platform compatibility by addressing a specific Windows compilation issue where the GetObject method name in protobuf definitions conflicted with a macro in windows.h.
• gRPC Port Definitions Integration: Integrated gRPC's ports_def.inc and ports_undef.inc headers into generated C++ client libraries to manage problematic preprocessor macros.
• Automated Code Generation Update: Modified the code generation logic to automatically include these gRPC port definition files in relevant generated C++ headers and source files.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a Windows portability issue where the GetObject macro conflicts with method names in our generated code. The fix involves including grpcpp/ports_def.inc and grpcpp/ports_undef.inc around our code to undefine the problematic macro.

The changes are implemented correctly by:

• Introducing new helper methods in ServiceCodeGenerator to handle the inclusion of the gRPC porting headers.
• Updating all relevant code generators to use these new methods, ensuring that all generated files will include the necessary headers.
• Regenerating a large number of files to apply the fix.

The changes are extensive but mechanical and necessary for Windows compatibility. The implementation is clean and correct. I have no further comments.

[codecov]

Codecov Report

❌ Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.86%. Comparing base (8b8506e) to head (af0ecc5).
⚠️ Report is 1 commits behind head on prepare-for-v3.0.0.

Files with missing lines	Patch %	Lines
...erator/internal/round_robin_decorator_generator.cc	0.00%	4 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           prepare-for-v3.0.0   #15923   +/-   ##
===================================================
  Coverage               92.86%   92.86%           
===================================================
  Files                    2343     2343           
  Lines                  216218   216258   +40     
===================================================
+ Hits                   200795   200835   +40     
  Misses                  15423    15423           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.