Skip to content

Make SuppressibleTreePathScanner respect errorProneOptions().isIgnoreSuppressionAnnotations() #5255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make SuppressibleTreePathScanner respect errorProneOptions().isIgnoreSuppressionAnnotations() #5255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions check_api/src/main/java/com/google/errorprone/bugpatterns/BugChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,6 +641,11 @@ public R scan(TreePath treePath, P param) {
}

private boolean suppressed(Tree tree) {
boolean ignoreSuppressions = state.errorProneOptions().isIgnoreSuppressionAnnotations();
if (ignoreSuppressions) {
return false;
}

boolean isSuppressible =
tree instanceof ClassTree || tree instanceof MethodTree || tree instanceof VariableTree;
return isSuppressible && isSuppressed(tree, state);
Expand Down
20 changes: 20 additions & 0 deletions core/src/test/java/com/google/errorprone/bugpatterns/BugCheckerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,26 @@ String s(Runnable r) {
.doTest();
}

@Test
public void suppressibleTreePathScanner_respectsIgnoreSuppressionAnnotationsFlag() {
CompilationTestHelper.newInstance(SuppressibleTreePathScannerCheck.class, getClass())
.setArgs("-XepIgnoreSuppressionAnnotations")
.addSourceLines(
"A.java",
"""
class A {
void m() {
// BUG: Diagnostic contains:
int unsuppressed;
@SuppressWarnings("foo")
// BUG: Diagnostic contains:
int suppressed;
}
}
""")
.doTest();
}

@Test
public void isSuppressed_disableWarningsInGeneratedCode() {
CompilationTestHelper.newInstance(CustomSuppressibilityCheck.class, getClass())
Expand Down