Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html5 play/pause events #1475

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
node_modules
package-lock.json
2 changes: 1 addition & 1 deletion dist/howler.core.min.js

Large diffs are not rendered by default.

28 changes: 28 additions & 0 deletions dist/howler.js
Original file line number Diff line number Diff line change
Expand Up @@ -2243,6 +2243,16 @@
self._loadFn = self._loadListener.bind(self);
self._node.addEventListener(Howler._canPlayEvent, self._loadFn, false);

// Listen for 'play' event to let us know when sound is played.
// This can be triggered externally by media keys (eg. TouchBar on MacOs for instance)
self._playFn = self._playListener.bind(self);
self._node.addEventListener('play', self._playFn, false);

// Listen for 'pause' event to let us know when sound is paused.
// This can be triggered externally by media keys (eg. TouchBar on MacOs for instance)
self._pauseFn = self._pauseListener.bind(self);
self._node.addEventListener('pause', self._pauseFn, false);

// Listen for the 'ended' event on the sound to account for edge-case where
// a finite sound has a duration of Infinity.
self._endFn = self._endListener.bind(self);
Expand Down Expand Up @@ -2323,6 +2333,24 @@
self._node.removeEventListener(Howler._canPlayEvent, self._loadFn, false);
},

/**
* HTML5 Audio play listener callback
* Sound is already played/paused so just update state and notify
*/
_playListener: function() {
this._paused = false;
this._parent._emit('play', this._id);
},

/**
* HTML5 Audio pause listener callback.
* Sound is already played/paused so just update state and notify
*/
_pauseListener: function() {
this._paused = true;
this._parent._emit('pause', this._id);
},

/**
* HTML5 Audio ended listener callback.
*/
Expand Down
2 changes: 1 addition & 1 deletion dist/howler.min.js

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions examples/player/player.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ Player.prototype = {
// Start the wave animation if we have already loaded
wave.container.style.display = 'block';
bar.style.display = 'none';
playBtn.style.display = 'none';
pauseBtn.style.display = 'block';
},
onload: function() {
Expand All @@ -85,6 +86,8 @@ Player.prototype = {
// Stop the wave animation.
wave.container.style.display = 'none';
bar.style.display = 'block';
playBtn.style.display = 'block';
pauseBtn.style.display = 'none';
},
onstop: function() {
// Stop the wave animation.
Expand Down Expand Up @@ -130,9 +133,6 @@ Player.prototype = {
// Puase the sound.
sound.pause();

// Show the play button.
playBtn.style.display = 'block';
pauseBtn.style.display = 'none';
},

/**
Expand Down
28 changes: 28 additions & 0 deletions src/howler.core.js
Original file line number Diff line number Diff line change
Expand Up @@ -2243,6 +2243,16 @@
self._loadFn = self._loadListener.bind(self);
self._node.addEventListener(Howler._canPlayEvent, self._loadFn, false);

// Listen for 'play' event to let us know when sound is played.
// This can be triggered externally by media keys (eg. TouchBar on MacOs for instance)
self._playFn = self._playListener.bind(self);
self._node.addEventListener('play', self._playFn, false);

// Listen for 'pause' event to let us know when sound is paused.
// This can be triggered externally by media keys (eg. TouchBar on MacOs for instance)
self._pauseFn = self._pauseListener.bind(self);
self._node.addEventListener('pause', self._pauseFn, false);

// Listen for the 'ended' event on the sound to account for edge-case where
// a finite sound has a duration of Infinity.
self._endFn = self._endListener.bind(self);
Expand Down Expand Up @@ -2323,6 +2333,24 @@
self._node.removeEventListener(Howler._canPlayEvent, self._loadFn, false);
},

/**
* HTML5 Audio play listener callback
* Sound is already played/paused so just update state and notify
*/
_playListener: function() {
this._paused = false;
this._parent._emit('play', this._id);
},

/**
* HTML5 Audio pause listener callback.
* Sound is already played/paused so just update state and notify
*/
_pauseListener: function() {
this._paused = true;
this._parent._emit('pause', this._id);
},

/**
* HTML5 Audio ended listener callback.
*/
Expand Down