Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html5 play/pause events #1475

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+63 −5
Open

html5 play/pause events #1475

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b44588
html5 play/pause events
nbonamy Mar 30, 2021
cf0f9a1
fix: pause sent by html5 at end of track
nbonamy Mar 30, 2021
ceafc2a
play/pause fix at end of stream
nbonamy Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
play/pause fix at end of stream
@nbonamy
nbonamy committed Mar 30, 2021
commit ceafc2aa68551be702c347b0e78d24cc2eadd16f
2 changes: 1 addition & 1 deletion dist/howler.core.min.js
View file

Large diffs are not rendered by default.

7 changes: 5 additions & 2 deletions dist/howler.js
View file
Original file line number Diff line number Diff line change
@@ -2334,7 +2334,8 @@
},

/**
* HTML5 Audio play listener callback.
* HTML5 Audio play listener callback
* Sound is already played/paused so just update state and notify
*/
_playListener: function() {
this._paused = false;
@@ -2343,9 +2344,11 @@

/**
* HTML5 Audio pause listener callback.
* Sound is already played/paused so just update state and notify
*/
_pauseListener: function() {
this._parent.pause(this._id);
this._paused = true;
this._parent._emit('pause', this._id);
},

/**
2 changes: 1 addition & 1 deletion dist/howler.min.js
View file

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion src/howler.core.js
View file
Original file line number Diff line number Diff line change
@@ -2334,7 +2334,8 @@
},

/**
* HTML5 Audio play listener callback.
* HTML5 Audio play listener callback
* Sound is already played/paused so just update state and notify
*/
_playListener: function() {
this._paused = false;
@@ -2343,6 +2344,7 @@

/**
* HTML5 Audio pause listener callback.
* Sound is already played/paused so just update state and notify
*/
_pauseListener: function() {
this._paused = true;