Skip to content

Conversation

@jinyangcruise
Copy link
Contributor

Fix #113536.

Inspired by #113510.

@jinyangcruise jinyangcruise requested review from a team as code owners December 4, 2025 06:54
@AThousandShips AThousandShips added this to the 4.6 milestone Dec 4, 2025
@AThousandShips AThousandShips added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Dec 4, 2025
@AThousandShips AThousandShips requested a review from KoBeWi December 4, 2025 09:41
@KoBeWi
Copy link
Member

KoBeWi commented Dec 4, 2025

The Recent list also needs to be fixed.

And these get_slicecs should be removed 😬

search_box->set_text(recent->get_item_text(p_idx).get_slicec(' ', 0));

search_box->set_text(item->get_text(0).get_slicec(' ', 0));

EDIT:
There is actually more useless get_slicec() calls in this file. They should be removed from anything that doesn't get text from the main tree.

@jinyangcruise jinyangcruise force-pushed the fix_unexpected_name_when_favoriting_nodes branch from 2aab730 to 28b1426 Compare December 4, 2025 12:23
@jinyangcruise
Copy link
Contributor Author

The Recent list also needs to be fixed.

And these get_slicecs should be removed 😬

search_box->set_text(recent->get_item_text(p_idx).get_slicec(' ', 0));

search_box->set_text(item->get_text(0).get_slicec(' ', 0));

EDIT: There is actually more useless get_slicec() calls in this file. They should be removed from anything that doesn't get text from the main tree.

Yes, some are useless. Modified.

@KoBeWi
Copy link
Member

KoBeWi commented Dec 4, 2025

This also doesn't need get_slicec():

const String &type_name = p_type.get_slicec(' ', 0);

@jinyangcruise jinyangcruise force-pushed the fix_unexpected_name_when_favoriting_nodes branch from 28b1426 to 8402065 Compare December 4, 2025 13:45
@akien-mga akien-mga merged commit 37b00ce into godotengine:master Dec 4, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@jinyangcruise jinyangcruise deleted the fix_unexpected_name_when_favoriting_nodes branch December 4, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release topic:editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected name when favoriting nodes from keyword matches

4 participants