Merge pull request #113554 from akien-mga/vcs-fix-OptionButton-indexing

VCS: Properly use IDs for OptionButton after #113522

Author: akien-mga

editor/version_control/version_control_editor_plugin.cpp

@@ -60,7 +60,7 @@ void VersionControlEditorPlugin::_bind_methods() {
 
 void VersionControlEditorPlugin::_create_vcs_metadata_files() {
 	String dir = "res://";
-	EditorVCSInterface::create_vcs_metadata_files(EditorVCSInterface::VCSMetadata(metadata_selection->get_selected()), dir);
+	EditorVCSInterface::create_vcs_metadata_files(EditorVCSInterface::VCSMetadata(metadata_selection->get_selected_id()), dir);
 }
 
 void VersionControlEditorPlugin::_notification(int p_what) {
@@ -959,7 +959,7 @@ VersionControlEditorPlugin::VersionControlEditorPlugin() {
 	metadata_selection = memnew(OptionButton);
 	metadata_selection->set_custom_minimum_size(Size2(100, 20));
 	metadata_selection->add_item("Git", (int)EditorVCSInterface::VCSMetadata::GIT);
-	metadata_selection->select((int)EditorVCSInterface::VCSMetadata::GIT);
+	metadata_selection->select(metadata_selection->get_item_index((int)EditorVCSInterface::VCSMetadata::GIT));
 	metadata_hb->add_child(metadata_selection);
 
 	l = memnew(Label);