Add support for borders for scatter layers #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for borders for scatter layers. Via the layer state, one can adjust whether to show borders, what border color to use, and what the border size should be.
In order to keep things from becoming too complicated, this doesn't allow using a colormap for the borders. However, there might be a case where a user wants to display unfilled circles with the layer colormapping for the borders. In order to allow this, this adds a
border_color_match_layerflag in the layer state - when this is set to true, the border color is ignored and the layer coloring (fixed or colormap) is used instead.