Bump glue-plotly version to 0.12 #747
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps our version of
glue-plotlyto 0.12 so that we can use the border styling added for scatter layers in that version. The relevant PR is here, but what's important for us is a few updates to the layer state. In particular:layer.state.border_visible- set this toTrueto display borderslayer.state.border_size- adjusts the size of the borderslayer.state.border_color- sets the color of the borderFor anyone who looks at the linked PR - the
border_color_match_layerisn't something that we need - the intended use case there is for making the borders match the colors of a colormapped layer if you want to have unfilled circles.