fix(github): sanitize release and project status-update bodies on read paths - #3040
Open
SashaMIT wants to merge 1 commit into
Open
fix(github): sanitize release and project status-update bodies on read paths#3040SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
…d paths Sibling of github#3035/github#3039: convertToMinimalRelease and convertToMinimalStatusUpdate still returned raw user-authored text to the model. Apply sanitize.Sanitize to release name/body and status-update body. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue/PR/review/Discussion read paths already run through
sanitize.Sanitize(invisible Unicode tags, BiDi overrides, HTML, code-fence metadata) before content reaches the model (#3035 / #3039). Two sibling user-authored surfaces still returned raw text:convertToMinimalRelease) — name and body verbatim.convertToMinimalStatusUpdate) — body verbatim.A hostile release note or status-update body could therefore carry hidden prompt-injection payloads into the context window, bypassing the baseline control its siblings apply.
Fix
Apply the same
sanitize.Sanitizeon those converters. No behavior change for clean content.Testing
Also:
go test ./pkg/github/ ./pkg/sanitize/locally green for the touched packages.Made with Cursor