fix(github): sanitize gist description and file bodies on read paths - #3043
Open
SashaMIT wants to merge 1 commit into
Open
fix(github): sanitize gist description and file bodies on read paths#3043SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
Sibling of github#3035/github#3039/github#3040: list_gists and get_gist still returned raw user-authored gist text to the model. Apply sanitize.Sanitize to description and file contents before marshal. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_gists/get_giststill marshaled raw gistdescriptionand filecontentinto the model context.sanitize.Sanitizepath used for issue/PR/release bodies (fix(github): sanitize issue comment and sub-issue bodies on read paths #3035 / fix(github): sanitize PR review and discussion bodies on read paths #3039 / fix(github): sanitize release and project status-update bodies on read paths #3040).Test plan
go test ./pkg/github/ -run 'TestSanitizeGist|Test_GetGist|Test_ListGists' -count=1Tooling assist used for prep; commit authored/signed by me (no Cursor co-author trailer).
Made with Cursor