feat(insights): Refactor chart widgets to pass down prop overrides #89455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
billyvg
commented
Apr 12, 2025
| ); | ||
|
|
||
| return ( | ||
| <InsightsLineChartWidget | ||
| id="httpDomainSummaryResponseCodesWidget" | ||
| {...props} | ||
| id="httpDomainSummaryResponseCodesChartWidget" |
There was a problem hiding this comment.
Gj cursor on autofixing this I guess
gggritso
reviewed
Apr 14, 2025
There was a problem hiding this comment.
Makes sense, but I think that sub prefix is a little strange.
IMO, for hooks like useDiscoverSeries, calling the prop pageFilters is pretty natural, those hooks are generic, and they probably should accept pageFilters as a prop. Same for InsightsTimeSeriesWidget. That props is passed to BaseChart anyway, so it makes sense to override it with something called just pageFilters. I'm less sure about InsightsTimeSeriesWidget, but even there it seems okay to omit the prefix
Comment on lines
+8
to
+11
| // TODO(billy): This should be required when all chart widgets are converted | ||
| /** | ||
| * Unique ID for the widget | ||
| */ |
There was a problem hiding this comment.
That makes sense, but if that's the case, TimeSeriesWidgetVisualization should use Partial<LoadableChartWidgetProps>. ID shouldn't be required there, just for the Insights chart
Inside of the Releases Drawers, we are only viewing a smaller slice of time than the main PageFilters. The chart widgets and their hooks need to support a pageFilters override. I think env/projects should be the same, but I think it will be more consistent to pass around the full pageFilters object. `showReleaseAs` is also needed since we currently show lines inside of the drawer, and bubbles outside of it.
billyvg
force-pushed
the
feat-insights-pass-props-to-insights-chart-widgets
branch
from
b3d7b19 to
770da7b
Compare
billyvg
commented
Apr 14, 2025
There was a problem hiding this comment.
Missed this bc i had inclusion list with only *.tsx :/
❌ 13 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
gggritso
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside of the Releases Drawers, we are only viewing a smaller slice of
time than the main PageFilters. The chart widgets and their hooks need
to support a pageFilters override. I think env/projects should be the
same, but I think it will be more consistent to pass around the full
pageFilters object.
showReleaseAsis also needed since we currentlyshow lines inside of the drawer, and bubbles outside of it.
Need as part of #88560