Skip to content

Commit 770da7b

Browse files
committed
subPageFilters -> pageFilters
1 parent 9c5ad94 commit 770da7b

9 files changed

+17
-16
lines changed

static/app/views/dashboards/widgets/timeSeriesWidget/timeSeriesWidgetVisualization.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ import {TimeSeriesWidgetYAxis} from './timeSeriesWidgetYAxis';
5656

5757
const {error, warn, info} = Sentry.logger;
5858

59-
export interface TimeSeriesWidgetVisualizationProps extends Partial<LoadableChartWidgetProps> {
59+
export interface TimeSeriesWidgetVisualizationProps
60+
extends Partial<LoadableChartWidgetProps> {
6061
/**
6162
* An array of `Plottable` objects. This can be any object that implements the `Plottable` interface.
6263
*/
@@ -112,7 +113,7 @@ export function TimeSeriesWidgetVisualization(props: TimeSeriesWidgetVisualizati
112113

113114
const pageFilters = usePageFilters();
114115
const {start, end, period, utc} =
115-
props.subPageFilters?.datetime || pageFilters.selection.datetime;
116+
props.pageFilters?.datetime || pageFilters.selection.datetime;
116117

117118
const theme = useTheme();
118119
const organization = useOrganization();

static/app/views/insights/common/components/insightsTimeSeriesWidget.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export function InsightsTimeSeriesWidget(props: InsightsTimeSeriesWidgetProps) {
5353
const theme = useTheme();
5454
const organization = useOrganization();
5555
const pageFilters = usePageFilters();
56-
const pageFiltersSelection = props.subPageFilters || pageFilters.selection;
56+
const pageFiltersSelection = props.pageFilters || pageFilters.selection;
5757
const {releases: releasesWithDate} = useReleaseStats(pageFiltersSelection);
5858
const releases =
5959
releasesWithDate?.map(({date, version}) => ({
@@ -131,7 +131,7 @@ export function InsightsTimeSeriesWidget(props: InsightsTimeSeriesWidgetProps) {
131131
Visualization={
132132
<TimeSeriesWidgetVisualization
133133
id={props.id}
134-
subPageFilters={props.subPageFilters}
134+
pageFilters={props.pageFilters}
135135
{...enableReleaseBubblesProps}
136136
legendSelection={props.legendSelection}
137137
onLegendSelectionChange={props.onLegendSelectionChange}

static/app/views/insights/common/components/widgets/httpDomainSummaryDurationChartWidget.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export default function HttpDomainSummaryDurationChartWidget(
2222
transformAliasToInputFormat: true,
2323
},
2424
Referrer.DOMAIN_SUMMARY_DURATION_CHART,
25-
props.subPageFilters
25+
props.pageFilters
2626
);
2727

2828
return (

static/app/views/insights/common/components/widgets/httpDomainSummaryResponseCodesChartWidget.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export default function HttpDomainSummaryResponseCodesChartWidget(
2222
transformAliasToInputFormat: true,
2323
},
2424
Referrer.DOMAIN_SUMMARY_RESPONSE_CODE_CHART,
25-
props.subPageFilters
25+
props.pageFilters
2626
);
2727

2828
return (

static/app/views/insights/common/components/widgets/httpDomainSummaryThroughputChartWidget.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export default function HttpDomainSummaryThroughputChartWidget(
2121
transformAliasToInputFormat: true,
2222
},
2323
Referrer.DOMAIN_SUMMARY_THROUGHPUT_CHART,
24-
props.subPageFilters
24+
props.pageFilters
2525
);
2626

2727
return (

static/app/views/insights/common/components/widgets/httpDurationChartWidget.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export default function HttpDurationChartWidget(props: LoadableChartWidgetProps)
1919
transformAliasToInputFormat: true,
2020
},
2121
Referrer.LANDING_DURATION_CHART,
22-
props.subPageFilters
22+
props.pageFilters
2323
);
2424

2525
return (

static/app/views/insights/common/components/widgets/httpResponseCodesChartWidget.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export default function HttpResponseCodesChartWidget(props: LoadableChartWidgetP
2020
transformAliasToInputFormat: true,
2121
},
2222
Referrer.LANDING_RESPONSE_CODE_CHART,
23-
props.subPageFilters
23+
props.pageFilters
2424
);
2525

2626
return (

static/app/views/insights/common/components/widgets/httpThroughputChartWidget.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export default function HttpThroughputChartWidget(props: LoadableChartWidgetProp
1919
transformAliasToInputFormat: true,
2020
},
2121
Referrer.LANDING_THROUGHPUT_CHART,
22-
props.subPageFilters
22+
props.pageFilters
2323
);
2424

2525
return (

static/app/views/insights/common/components/widgets/types.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@ export interface LoadableChartWidgetProps {
1111
*/
1212
id?: string;
1313

14-
/**
15-
* Show releases as either lines per release or a bubble for a group of releases.
16-
*/
17-
showReleaseAs?: 'bubble' | 'line';
18-
1914
/**
2015
* PageFilters-like object that will override the main PageFilters e.g. in
2116
* Releases Drawer, we have a smaller timeframe to show a smaller amount of
2217
* releases.
2318
*/
24-
subPageFilters?: PageFilters;
19+
pageFilters?: PageFilters;
20+
21+
/**
22+
* Show releases as either lines per release or a bubble for a group of releases.
23+
*/
24+
showReleaseAs?: 'bubble' | 'line';
2525
}

0 commit comments

Comments
 (0)