feat(difs): Set filename metadata on Objectstore-backed DIFs#119308
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
Debug file uploads to Objectstore now pass a `filename` derived from the debug ID and file extension, matching what the download endpoint already sets as the Content-Disposition filename. Extracted the extension logic from ProjectDebugFile.file_extension into a standalone helper so it can be computed before the ProjectDebugFile row exists.
lcian
force-pushed
the
lcian/feat/objectstore-debugfile-filename
branch
from
2f896af to
dfe684d
Compare
lcian
changed the title
jan-auer
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debug file uploads to Objectstore now pass a
filename, built from the debug ID and file extension, so it matches the filename we already return in theContent-Dispositionheader on download:sentry/src/sentry/api/endpoints/debug_files.py
Line 292 in 7b06010
Previously
initiate_multipart_uploadwas called without a filename, so Objectstore had no name to associate with the object.This is needed in preparation for a follow-up PR where we'll issue 302 redirects to Objectstore for downloads instead of streaming them through Sentry. With this change, Objectstore will set the
content-disposition, so downloads will continue to work with no behavioral change for customers.Close FS-418