feat(difs): Redirect to Objectstore for Objectstore-backed DIF downloads#119392
Open
lcian wants to merge 3 commits into
Open
feat(difs): Redirect to Objectstore for Objectstore-backed DIF downloads#119392lcian wants to merge 3 commits into
lcian wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
Scope: Backend
Replace urllib.request.urlopen with requests.get in _assert_successful_download so we can assert on response headers (status code, Content-Disposition) in addition to body content. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SwFR1j8BHYWjkHBG8FsSog
lcian
changed the title
lcian
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 292067c. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it so that Objectstore-backed DIFs are downloaded by Symbolicator/browsers/other API users from Objectstore directly, without streaming them through Sentry. This is achieved by issuing a 302 redirect to a pre-signed URL that allows the user to get the object.
Close FS-401