Skip to content

fix(users): Assert user.id is not None before ORM get #107745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshFerge merged 1 commit into from
Feb 6, 2026
Merged

fix(users): Assert user.id is not None before ORM get #107745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sentry/users/api/endpoints/user_authenticator_enroll.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ def post(self, request: Request, user: User, interface_id: str) -> HttpResponse:

# Using `request.user` here because superuser/staff should not be able to set a user's 2fa
if user.id != request.user.id:
assert request.user.id is not None
Copy link
Member Author

@JoshFerge JoshFerge Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

annoying we have to do this as this in theory will never be possible, but only way to make the type checker happy.

user = User.objects.get(id=request.user.id)

# start activation
Expand Down
Loading