fix(users): Assert user.id is not None before ORM get#107745
Merged
fix(users): Assert user.id is not None before ORM get#107745
Conversation
Found during mypy / django-stubs upgrade in #107710.
github-actions
bot
added
the
Scope: Backend
2 tasks
JoshFerge
commented
Feb 5, 2026
|
|
||
| # Using `request.user` here because superuser/staff should not be able to set a user's 2fa | ||
| if user.id != request.user.id: | ||
| assert request.user.id is not None |
Member
Author
There was a problem hiding this comment.
annoying we have to do this as this in theory will never be possible, but only way to make the type checker happy.
kcons
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found during mypy / django-stubs upgrade in #107710.
Adds
assert request.user.id is not NonebeforeUser.objects.get(id=request.user.id)in the authenticator enrollment endpoint.user.idis typed asint | None.Test plan