Skip to content

ref(core): Strengthen browserPerformanceTimeOrigin reliability check #18719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 1 commit into from
Jan 8, 2026
Merged

ref(core): Strengthen browserPerformanceTimeOrigin reliability check #18719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/core/src/utils/time.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,7 @@ function getBrowserTimeOrigin(): number | undefined {
return undefined;
}

// TOOD: We should probably set a much tighter threshold here as skew can already happen within just a few minutes.
const threshold = 3_600_000; // 1 hour in milliseconds
const threshold = 300_000; // 5 minutes in milliseconds
const performanceNow = performance.now();
const dateNow = Date.now();

Expand Down
2 changes: 1 addition & 1 deletion packages/core/test/lib/utils/time.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ async function getFreshPerformanceTimeOrigin() {
return timeModule.browserPerformanceTimeOrigin();
}

const RELIABLE_THRESHOLD_MS = 3_600_000;
const RELIABLE_THRESHOLD_MS = 300_000;

describe('browserPerformanceTimeOrigin', () => {
it('returns `performance.timeOrigin` if it is available and reliable', async () => {
Expand Down
Loading