ref(core): Strengthen browserPerformanceTimeOrigin reliability check
#18719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
browserPerformanceTimeOrigin, we test how reliableperformance.timeOrigin(or its predecessor) is by comparing its timestamp againstperformance.now() - Date.now(). If the delta is larger than 1h, we take the fallback rather thanperformance.timeOrigin.For some context, we do this because
performance.timeOriginis prone to several inaccuracies, most prominently because it will drift behind the actual current time if users suspend their devices (e.g. closing a laptop, shutting of a phone). This makes the monotonic clock oftimeOriginresume where it left off prior to the suspension. It does not resync with the actual wall clock time (for better or worse).This PR now makes the reliability check more strict by decreasing the time window from 1h to just 5 minutes. This should catch time drift more often. Now that we improved the fallback via #18715, I think we can give this a shot.