Skip to content

ref(browser): Remove unnecessary CLS web vital check #17090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −4
Open

ref(browser): Remove unnecessary CLS web vital check #17090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/browser-utils/src/metrics/browserMetrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,10 +430,8 @@ export function addPerformanceEntries(span: Span, options: AddPerformanceEntries
delete _measurements['mark.fid'];
}

// If FCP is not recorded we should not record the cls value
// according to the new definition of CLS.
// TODO: Check if the first condition is still necessary: `onCLS` already only fires once `onFCP` was called.
if (!('fcp' in _measurements) || !options.recordClsOnPageloadSpan) {
// If CLS standalone spans are enabled, don't record CLS as a measurement
if (!options.recordClsOnPageloadSpan) {
delete _measurements.cls;
}

Expand Down
Loading