Skip to content

ref(browser): Remove unnecessary CLS web vital check #17090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jul 18, 2025

Just a minor cleanup from a TODO I left a while ago. We can safely remove this check because CLS isn't reported before FCP is reported:

onFCP(
runOnce(() => {
const metric = initMetric('CLS', 0);
let report: ReturnType<typeof bindReporter>;

Adjusted the comment as well, since we now only need to handle the standalone span case.

@Lms24 Lms24 self-assigned this Jul 18, 2025
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.75 kB - -
@sentry/browser - with treeshaking flags 22.34 kB - -
@sentry/browser (incl. Tracing) 39.61 kB -0.02% -6 B 🔽
@sentry/browser (incl. Tracing, Replay) 77.78 kB -0.01% -7 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.59 kB -0.02% -7 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 82.48 kB -0.01% -8 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 94.58 kB -0.01% -9 B 🔽
@sentry/browser (incl. Feedback) 40.45 kB - -
@sentry/browser (incl. sendFeedback) 28.43 kB - -
@sentry/browser (incl. FeedbackAsync) 33.34 kB - -
@sentry/react 25.5 kB - -
@sentry/react (incl. Tracing) 41.59 kB -0.02% -7 B 🔽
@sentry/vue 28.18 kB - -
@sentry/vue (incl. Tracing) 41.4 kB -0.02% -8 B 🔽
@sentry/svelte 23.78 kB - -
CDN Bundle 25.18 kB - -
CDN Bundle (incl. Tracing) 39.41 kB -0.02% -7 B 🔽
CDN Bundle (incl. Tracing, Replay) 75.41 kB -0.01% -5 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 80.88 kB -0.01% -7 B 🔽
CDN Bundle - uncompressed 73.44 kB - -
CDN Bundle (incl. Tracing) - uncompressed 116.85 kB -0.02% -12 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 230.99 kB -0.01% -12 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 243.8 kB -0.01% -12 B 🔽
@sentry/nextjs (client) 43.61 kB -0.02% -7 B 🔽
@sentry/sveltekit (client) 40.03 kB -0.02% -7 B 🔽
@sentry/node-core 47.24 kB - -
@sentry/node 143.81 kB - -
@sentry/node - without tracing 91.31 kB - -
@sentry/aws-serverless 102.75 kB - -

View base workflow run

Copy link

codecov bot commented Jul 18, 2025

❌ Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:
Error deserializing json

Caused by:
expected value at line 1 column 1

For more help, visit our troubleshooting guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants