Skip to content

Relax Android Version Constraint & Only Include main dependencies we need #4100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Relax Android Version Constraint & Only Include main dependencies we need #4100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2cce05e
Remove specific nuget references to allow transitives to be pulled & …
aritchie Apr 10, 2025
b980414
Update CHANGELOG.md
aritchie Apr 10, 2025
41f1c3f
Merge branch 'main' into pr/4100
jamescrosswell Apr 10, 2025
931aa8b
Merge branch 'main' into 4095-fix_android_dependencies
aritchie Apr 11, 2025
1011eb1
Update Sentry.Bindings.Android.csproj
aritchie Apr 11, 2025
8307270
Merge branch 'main' into 4095-fix_android_dependencies
aritchie Apr 15, 2025
be4c593
Testing versions specific to what sentry needs at bare min - ignoring…
aritchie Apr 15, 2025
00b722d
Try another set of versions that also support netcore+
aritchie Apr 15, 2025
54bb209
Merge branch 'main' into 4095-fix_android_dependencies
aritchie Apr 16, 2025
bd07a5b
Merge branch 'main' into 4095-fix_android_dependencies
aritchie Apr 25, 2025
f64ae40
Merge branch 'main' into 4095-fix_android_dependencies
jamescrosswell May 16, 2025
5d1565e
Test with Microsoft.Maui.Essentials 9.0.50
jamescrosswell May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@

### Fixes

- Relax Android Version Dependency and reference only Xamarin.AndroidX.Lifecycle.Process allowing other transitive libraries to pull our dependency versions forward ([#4100](https://github.com/getsentry/sentry-dotnet/pull/4100))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 The changelog entry seems to be part of an already released section ## 5.7.0.
    Consider moving the entry to the ## Unreleased section, please.

- Ensure user exception data is not removed by AspNetCoreExceptionProcessor ([#4016](https://github.com/getsentry/sentry-dotnet/pull/4106))
- Prevent users from disabling AndroidEnableAssemblyCompression which leads to untrappable crash ([#4089](https://github.com/getsentry/sentry-dotnet/pull/4089))
- Fixed MSVCRT build warning on Windows ([#4111](https://github.com/getsentry/sentry-dotnet/pull/4111))
Expand Down
1 change: 1 addition & 0 deletions samples/Sentry.Samples.Maui/Sentry.Samples.Maui.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Maui.Controls" Version="$(MauiVersion)" />
<PackageReference Include="Microsoft.Maui.Essentials" Version="9.0.50" />
</ItemGroup>

<!--In order to test our analyzers with this project, we manually reference our targets file. User do not need to do this-->
Expand Down
30 changes: 7 additions & 23 deletions src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,29 +29,13 @@
<InternalsVisibleTo Include="Sentry.Maui.Tests" PublicKey="$(SentryPublicKey)" />
</ItemGroup>

<!-- Dependencies for AndroidMavenLibrary references
Note: versions match what was shipped with net8.0-android34.0 in:
https://www.nuget.org/packages/Microsoft.Maui.Core/8.0.3#dependencies-body-tab
-->
<ItemGroup Condition="$(TargetFramework.StartsWith('net8'))">
<PackageReference Include="Xamarin.AndroidX.Lifecycle.Process" Version="2.6.1.3" />
<PackageReference Include="Xamarin.AndroidX.Lifecycle.Common.Java8" Version="2.6.1.3" />
<!-- MAUI 8 references this version indirectly via Xamarin.AndroidX.SwipeRefreshLayout (>= 1.1.0.14) -->
<PackageReference Include="Xamarin.AndroidX.Core" Version="1.10.1.2" />
<!-- We need 1.9.24 but there's no NuGet package for that version... the lowest version we can use is 2.0.0 -->
<PackageReference Include="Xamarin.Kotlin.StdLib.Jdk8" Version="2.0.0" />
</ItemGroup>

<!-- Dependencies for AndroidMavenLibrary references
Note: versions match what was shipped with net9.0-android35.0 in:
https://www.nuget.org/packages/Microsoft.Maui.Core/9.0.0#dependencies-body-tab
-->
<ItemGroup Condition="$(TargetFramework.StartsWith('net9'))">
<PackageReference Include="Xamarin.AndroidX.Lifecycle.Process" Version="2.8.5.1" />
<PackageReference Include="Xamarin.AndroidX.Lifecycle.Common.Java8" Version="2.8.5.1" />
<!-- MAUI 9 references this version indirectly via Xamarin.AndroidX.SwipeRefreshLayout (>= 1.1.0.24) -->
<PackageReference Include="Xamarin.AndroidX.Core" Version="1.13.1.5" />
<!-- We need 1.9.24 but there's no NuGet package for that version... the lowest version we can use is 2.0.0 -->
<!--
Dependencies for AndroidMavenLibrary references
That meet the version need by sentry.java and satify the first versions of NETX (netcore) that are available on nuget-->
<ItemGroup>
<PackageReference Include="Xamarin.AndroidX.Lifecycle.Common.Java8" Version="2.4.1" />
<PackageReference Include="Xamarin.AndroidX.Lifecycle.Process" Version="2.5.0" />
<PackageReference Include="Xamarin.AndroidX.Core" Version="1.7.0" />
<PackageReference Include="Xamarin.Kotlin.StdLib.Jdk8" Version="2.0.0" />
</ItemGroup>

Expand Down
Loading