Relax Android Version Constraint & Only Include main dependencies we need #4100
Conversation
…relax version constraint
… java ref issues by suggestion from dotnet android team member
|
@jamescrosswell might be good to release this as a beta so the nupkg gets fully packaged. I know the user that is waiting for this would be happy to help test as well |
aritchie
changed the title
|
We could test this PR by adding Microsoft.Maui.Essentials 9.0.50 to the Sentry.Samles.Maui.csproj. It wouldn't be a bullet proof test but if there are no diamond dependency warnings when we do that, it would indicate the dependency changes in this PR don't suffer from all the same constraints as our existing depdencies. Ideally we'd have a system to identify and update these dependencies in the future as well. The dependencies we currently reference were identified by the Roslyn analysers (i.e. that's our current system). If there's a better way, we should document it (in this PR at least). |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -52,6 +52,7 @@ | |||
|
|
|||
| ### Fixes | |||
|
|
|||
| - Relax Android Version Dependency and reference only Xamarin.AndroidX.Lifecycle.Process allowing other transitive libraries to pull our dependency versions forward ([#4100](https://github.com/getsentry/sentry-dotnet/pull/4100)) | |||
There was a problem hiding this comment.
- 🚫 The changelog entry seems to be part of an already released section
## 5.7.0.
Consider moving the entry to the## Unreleasedsection, please.
|
Just tested by adding Microsoft.Maui.Essentials 9.0.50 to the Sample app and unfortunately this PR doesn't resolve the issue. That's not a massive surprise - there isn't even really a theoretical solution to the diamond dependency problem. At best, I think we'd be playing a game of whack-a-mol where we could get it going for some specific set of dependency versions but, at the same time, break it for another. Ultimately, I don't believe this problem can be fixed in the Sentry SDK. |
Resolves #4095