Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid showing top-level platform in search #13072

Merged
merged 2 commits into from
Mar 21, 2025
Merged

fix: Avoid showing top-level platform in search #13072

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ee9cbb
fix: Avoid showing top-level platform in search
mydea Mar 20, 2025
7161393
slightly easier
mydea Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/components/platformFilter/client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ export function PlatformFilterClient({platforms}: {platforms: Platform[]}) {
return matches_;
}, [filter, platformsAndGuides]);

const matchKeys = useMemo(() => {
return matches.map(x => x.key);
}, [matches]);

const platformColumns: Platform[][] = splitToChunks(
3,
uniqByReference(matches.map(x => (x.type === 'platform' ? x : x.platform))).map(p => {
Expand Down Expand Up @@ -161,6 +165,7 @@ export function PlatformFilterClient({platforms}: {platforms: Platform[]}) {
<PlatformWithGuides
key={platform.key}
platform={platform}
matchKeys={matchKeys}
// force expand if the filter is long enough to have few results
forceExpand={filter.length >= 2}
/>
Expand All @@ -180,11 +185,19 @@ export function PlatformFilterClient({platforms}: {platforms: Platform[]}) {
function PlatformWithGuides({
platform,
forceExpand,
matchKeys,
}: {
forceExpand: boolean;
matchKeys: string[];
platform: Platform;
}) {
const [expanded, setExpanded] = useState(false);

const guides = useMemo(() => {
const showPlatformInContent = !forceExpand || matchKeys.includes(platform.key);
return showPlatformInContent ? [platform, ...platform.guides] : platform.guides;
}, [forceExpand, matchKeys, platform]);

return (
<Collapsible.Root
className={styles.CollapsibleRoot}
Expand Down Expand Up @@ -217,7 +230,7 @@ function PlatformWithGuides({
// scrollable if there are more than 8 (arbitrary limit) guides
data-scrollable={platform.guides.length >= 8 || platform.integrations.length >= 8}
>
{[platform, ...platform.guides].map((guide, i) => (
{guides.map((guide, i) => (
<Link
href={guide.url}
style={{textDecoration: 'none', color: 'var(--foreground) !important'}}
Expand Down
Loading