Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid showing top-level platform in search #13072

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 20, 2025

If you search for something, e.g. "Next.js", we do not need to show the link to the top-level "JavaScript" entry in the platforms list.

Old

Screenshot 2025-03-20 at 16 56 33

New

Screenshot 2025-03-20 at 16 56 19

Note that if you search for the top-level term, it is still there - but only if the top-level entry actually matches the search term:

Screenshot 2025-03-20 at 16 56 24

If you search for something, e.g. "Next.js", we do not need to show the link to the top-level "JavaScript" entry in the platforms list.
@mydea mydea requested review from a-hariti and chargome March 20, 2025 15:57
@mydea mydea self-assigned this Mar 20, 2025
Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 8:54am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 8:54am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2025 8:54am

Copy link

codecov bot commented Mar 20, 2025

Bundle Report

Changes will increase total bundle size by 227 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.59MB 112 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.43MB 115 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.78kB -0.0%
static/chunks/3319-*.js -3 bytes 394.16kB -0.0%
static/chunks/app/[[...path]]/page-*.js 121 bytes 75.06kB 0.16%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/ghjTjVnUMw5H8FvjiIsgc/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/ghjTjVnUMw5H8FvjiIsgc/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/DC2qJ-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/DC2qJ-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/app/[[...path]]/page-*.js:

  • ./src/components/platformFilter/client.tsx → Total Size: 14.85kB
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.58MB -0.0%
../instrumentation.js -3 bytes 908.25kB -0.0%
9523.js -3 bytes 884.31kB -0.0%
../app/[[...path]]/page.js 121 bytes 534.93kB 0.02%

Files in ../app/[[...path]]/page.js:

  • ./src/components/platformFilter/client.tsx → Total Size: 505 bytes

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 121 bytes 3.08MB 0.0%

Copy link
Collaborator

@a-hariti a-hariti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all these docs prs! 🚀

@mydea mydea merged commit 28d68bf into master Mar 21, 2025
13 checks passed
@mydea mydea deleted the fn/avoid-platform-search branch March 21, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants