Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure integer value for rootMarginBottom #13059

Merged
merged 1 commit into from
Mar 21, 2025
+2 −1
Merged

fix: ensure integer value for rootMarginBottom #13059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/sidebarTableOfContents/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ export function SidebarTableOfContents() {
// account for the header height
const rootMarginTop = 100;
// element is consiered in view if it is in the top 1/3 of the screen
const rootMarginBottom = (2 / 3) * window.innerHeight - rootMarginTop;
const rootMarginBottomRaw = (2 / 3) * window.innerHeight - rootMarginTop;
const rootMarginBottom = Math.floor(rootMarginBottomRaw);
const observerOptions = {
rootMargin: `${rootMarginTop}px 0px -${rootMarginBottom}px 0px`,
threshold: 1,
Expand Down
Loading