Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure integer value for rootMarginBottom #13059

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

sentry-autofix[bot]
Copy link
Contributor

👋 Hi there! This PR was automatically generated by Autofix 🤖

This fix was triggered by [email protected]

Fixes DOCS-7VQ

  • Ensures that rootMarginBottom is an integer value by using Math.floor() on the raw calculated value.
  • This prevents the "Failed to construct 'IntersectionObserver'" error that can occur when a non-integer value is used for rootMargin.

If you have any questions or feedback for the Sentry team about this fix, please email [email protected] with the Run ID: 12048.

Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 4:36am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 4:36am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2025 4:36am

@trillville trillville marked this pull request as ready for review March 20, 2025 04:22
@trillville trillville requested a review from a team March 20, 2025 04:22
Copy link

codecov bot commented Mar 20, 2025

Bundle Report

Changes will decrease total bundle size by 3 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.58MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.43MB 6 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.16kB -0.0%
static/chunks/3319-*.js -3 bytes 393.41kB -0.0%
static/chunks/818-*.js 12 bytes 42.15kB 0.03%
static/FOQDu00RKmXifG55lvZVz/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/FOQDu00RKmXifG55lvZVz/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/tEnS8M5SxAvDq8870-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/tEnS8M5SxAvDq8870-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/818-*.js:

  • ./src/components/sidebarTableOfContents/index.tsx → Total Size: 5.62kB
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.57MB -0.0%
../instrumentation.js -3 bytes 904.32kB -0.0%
9523.js -3 bytes 880.37kB -0.0%

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful autofix

@chargome chargome merged commit 99a825c into master Mar 21, 2025
13 checks passed
@chargome chargome deleted the autofix/fix-integer-root-margin branch March 21, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant