Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
### Improvements

- Replace deprecated SCNetworkReachability with NWPathMonitor (#6019)
- Increase attachment max size to 100MB (#6537)

## 8.57.0

Expand Down
2 changes: 1 addition & 1 deletion Sources/Sentry/Public/SentryOptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ NS_SWIFT_NAME(Options)

/**
* The maximum size for each attachment in bytes.
* @note Default is 20 MiB (20 ✕ 1024 ✕ 1024 bytes).
* @note Default is 100 MiB (100 ✕ 1024 ✕ 1024 bytes).
* @note Please also check the maximum attachment size of relay to make sure your attachments don't
* get discarded there:
* https://docs.sentry.io/product/relay/options/
Expand Down
4 changes: 3 additions & 1 deletion Sources/Sentry/SentryOptions.m
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ - (instancetype)init
self.enableWatchdogTerminationTracking = YES;
self.sessionTrackingIntervalMillis = [@30000 unsignedIntValue];
self.attachStacktrace = YES;
self.maxAttachmentSize = 20 * 1024 * 1024;
// Maximum attachment size is 100 MiB, matches Relay's limit:
// https://develop.sentry.dev/sdk/data-model/envelopes/#size-limits
self.maxAttachmentSize = 100 * 1024 * 1024;
self.sendDefaultPii = NO;
self.enableAutoPerformanceTracing = YES;
self.enablePersistingTracesWhenCrashing = NO;
Expand Down
4 changes: 2 additions & 2 deletions Tests/SentryTests/SentryOptionsTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -724,7 +724,7 @@ - (void)assertDefaultValues:(SentryOptions *)options
XCTAssertEqual(YES, options.enableWatchdogTerminationTracking);
XCTAssertEqual([@30000 unsignedIntValue], options.sessionTrackingIntervalMillis);
XCTAssertEqual(YES, options.attachStacktrace);
XCTAssertEqual(20 * 1024 * 1024, options.maxAttachmentSize);
XCTAssertEqual(100 * 1024 * 1024, options.maxAttachmentSize);
XCTAssertEqual(NO, options.sendDefaultPii);
XCTAssertTrue(options.enableAutoPerformanceTracing);
#if SENTRY_HAS_UIKIT
Expand Down Expand Up @@ -854,7 +854,7 @@ - (void)testDefaultMaxAttachmentSize
{
SentryOptions *options = [self getValidOptions:@{}];

XCTAssertEqual(20 * 1024 * 1024, options.maxAttachmentSize);
XCTAssertEqual(100 * 1024 * 1024, options.maxAttachmentSize);
}

- (void)testSendDefaultPii
Expand Down
2 changes: 1 addition & 1 deletion scripts/.swiftlint-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.61.0
0.62.2
Loading