Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Oct 24, 2025

In accordance to #5913, increase the maximum attachment size

Part of #5913

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.794%. Comparing base (707c222) to head (c475bf2).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6537       +/-   ##
=============================================
- Coverage   85.899%   85.794%   -0.106%     
=============================================
  Files          451       451               
  Lines        27482     27328      -154     
  Branches     11970     11917       -53     
=============================================
- Hits         23607     23446      -161     
- Misses        3826      3839       +13     
+ Partials        49        43        -6     
Files with missing lines Coverage Δ
Sources/Sentry/SentryOptions.m 96.491% <100.000%> (-0.554%) ⬇️

... and 65 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 707c222...c475bf2. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1196.44 ms 1224.96 ms 28.52 ms
Size 23.75 KiB 1.00 MiB 1002.40 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7629df7 1224.80 ms 1250.29 ms 25.49 ms
db9572a 1223.13 ms 1241.60 ms 18.47 ms
76f74df 1238.29 ms 1261.22 ms 22.94 ms
9450cb4 1221.29 ms 1232.96 ms 11.67 ms
701b301 1226.10 ms 1245.57 ms 19.47 ms
079bcc8 1217.88 ms 1234.88 ms 17.00 ms
fdea6f5 1216.08 ms 1241.82 ms 25.73 ms
c30e401 1218.71 ms 1243.73 ms 25.02 ms
934eee4 1222.51 ms 1251.04 ms 28.53 ms
aa96485 1215.37 ms 1234.04 ms 18.67 ms

App size

Revision Plain With Sentry Diff
7629df7 23.75 KiB 959.45 KiB 935.70 KiB
db9572a 23.75 KiB 858.64 KiB 834.89 KiB
76f74df 23.75 KiB 879.61 KiB 855.86 KiB
9450cb4 23.75 KiB 908.55 KiB 884.80 KiB
701b301 23.75 KiB 867.16 KiB 843.41 KiB
079bcc8 23.74 KiB 874.07 KiB 850.33 KiB
fdea6f5 23.75 KiB 867.15 KiB 843.40 KiB
c30e401 23.74 KiB 971.70 KiB 947.96 KiB
934eee4 23.75 KiB 988.03 KiB 964.28 KiB
aa96485 23.75 KiB 874.46 KiB 850.71 KiB

Previous results on branch: itay/increase_attachment_size

Startup times

Revision Plain With Sentry Diff
9f5b838 1233.18 ms 1242.29 ms 9.11 ms

App size

Revision Plain With Sentry Diff
9f5b838 23.75 KiB 1.00 MiB 1005.08 KiB

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for tackling this.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update this public code comment

/**
* The maximum size for each attachment in bytes.
* @note Default is 20 MiB (20 ✕ 1024 ✕ 1024 bytes).
* @note Please also check the maximum attachment size of relay to make sure your attachments don't
* get discarded there:
* https://docs.sentry.io/product/relay/options/
*/
@property (nonatomic, assign) NSUInteger maxAttachmentSize;

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants