Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 4, 2025

Removes V9 checks for deprecated segment property and deprecated TraceContext initializers

#skip-changelog

Closes #6349, #4093

@codecov
Copy link

codecov bot commented Oct 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.849%. Comparing base (abafa5d) to head (eb4aa9b).
⚠️ Report is 14 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6348       +/-   ##
=============================================
- Coverage   86.933%   86.849%   -0.084%     
=============================================
  Files          452       452               
  Lines        37760     37650      -110     
  Branches     17475     17452       -23     
=============================================
- Hits         32826     32699      -127     
- Misses        4890      4907       +17     
  Partials        44        44               
Files with missing lines Coverage Δ
Sources/Sentry/SentryBaggage.m 100.000% <ø> (ø)
Sources/Sentry/SentryClient.m 99.317% <ø> (-0.010%) ⬇️
Sources/Sentry/SentryNetworkTracker.m 99.725% <ø> (-0.008%) ⬇️
Sources/Sentry/SentryTraceContext.m 96.946% <ø> (+0.992%) ⬆️
Sources/Sentry/SentryUser.m 95.488% <ø> (-0.919%) ⬇️
...wift/Protocol/Codable/SentryDebugMetaCodable.swift 100.000% <100.000%> (ø)
...ces/Swift/Protocol/Codable/SentryUserCodable.swift 100.000% <ø> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abafa5d...eb4aa9b. Read the comment docs.

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1197.07 ms 1219.65 ms 22.59 ms
Size 23.74 KiB 1022.37 KiB 998.62 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d157d83 1228.02 ms 1252.47 ms 24.45 ms
1fecbb8 1242.78 ms 1265.40 ms 22.62 ms
0529194 1237.23 ms 1254.67 ms 17.44 ms
354b020 1223.88 ms 1236.82 ms 12.94 ms
d3f650a 1225.45 ms 1241.86 ms 16.41 ms
3ec47ae 1231.02 ms 1256.67 ms 25.65 ms
e0e5391 1191.21 ms 1243.14 ms 51.93 ms
0309548 1225.04 ms 1252.82 ms 27.77 ms
5cfc768 1220.74 ms 1245.06 ms 24.32 ms
664c060 1215.48 ms 1244.41 ms 28.93 ms

App size

Revision Plain With Sentry Diff
d157d83 23.75 KiB 928.85 KiB 905.10 KiB
1fecbb8 23.75 KiB 969.28 KiB 945.53 KiB
0529194 23.74 KiB 891.02 KiB 867.28 KiB
354b020 23.75 KiB 878.19 KiB 854.44 KiB
d3f650a 23.75 KiB 902.48 KiB 878.73 KiB
3ec47ae 23.75 KiB 919.88 KiB 896.13 KiB
e0e5391 23.74 KiB 1022.21 KiB 998.46 KiB
0309548 23.75 KiB 994.74 KiB 970.99 KiB
5cfc768 23.75 KiB 850.73 KiB 826.98 KiB
664c060 23.74 KiB 977.41 KiB 953.67 KiB

Previous results on branch: v9Decodable

Startup times

Revision Plain With Sentry Diff
4463b8f 1222.04 ms 1252.11 ms 30.07 ms
887292b 1237.00 ms 1269.51 ms 32.51 ms
8142fa1 1236.86 ms 1269.24 ms 32.38 ms
e55704e 1224.78 ms 1255.50 ms 30.72 ms
69ea418 1216.50 ms 1255.47 ms 38.97 ms

App size

Revision Plain With Sentry Diff
4463b8f 23.75 KiB 986.67 KiB 962.92 KiB
887292b 23.75 KiB 991.17 KiB 967.43 KiB
8142fa1 23.75 KiB 991.24 KiB 967.50 KiB
e55704e 23.75 KiB 991.23 KiB 967.48 KiB
69ea418 23.75 KiB 991.31 KiB 967.57 KiB

@noahsmartin noahsmartin force-pushed the v9Decodable branch 3 times, most recently from c0e1099 to 4db48e2 Compare October 5, 2025 16:43
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@noahsmartin noahsmartin changed the title chore: Remove V9 checks for decodable and segment chore: Remove V9 checks for segment Oct 7, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryNetworkTracker.m

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin merged commit 5cd61e0 into main Oct 23, 2025
184 of 188 checks passed
@noahsmartin noahsmartin deleted the v9Decodable branch October 23, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Remove V9 checks for decodable and segment

3 participants