-
-
Notifications
You must be signed in to change notification settings - Fork 369
chore: Remove V9 checks for segment #6348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6348 +/- ##
=============================================
- Coverage 86.933% 86.849% -0.084%
=============================================
Files 452 452
Lines 37760 37650 -110
Branches 17475 17452 -23
=============================================
- Hits 32826 32699 -127
- Misses 4890 4907 +17
Partials 44 44
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d157d83 | 1228.02 ms | 1252.47 ms | 24.45 ms |
| 1fecbb8 | 1242.78 ms | 1265.40 ms | 22.62 ms |
| 0529194 | 1237.23 ms | 1254.67 ms | 17.44 ms |
| 354b020 | 1223.88 ms | 1236.82 ms | 12.94 ms |
| d3f650a | 1225.45 ms | 1241.86 ms | 16.41 ms |
| 3ec47ae | 1231.02 ms | 1256.67 ms | 25.65 ms |
| e0e5391 | 1191.21 ms | 1243.14 ms | 51.93 ms |
| 0309548 | 1225.04 ms | 1252.82 ms | 27.77 ms |
| 5cfc768 | 1220.74 ms | 1245.06 ms | 24.32 ms |
| 664c060 | 1215.48 ms | 1244.41 ms | 28.93 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d157d83 | 23.75 KiB | 928.85 KiB | 905.10 KiB |
| 1fecbb8 | 23.75 KiB | 969.28 KiB | 945.53 KiB |
| 0529194 | 23.74 KiB | 891.02 KiB | 867.28 KiB |
| 354b020 | 23.75 KiB | 878.19 KiB | 854.44 KiB |
| d3f650a | 23.75 KiB | 902.48 KiB | 878.73 KiB |
| 3ec47ae | 23.75 KiB | 919.88 KiB | 896.13 KiB |
| e0e5391 | 23.74 KiB | 1022.21 KiB | 998.46 KiB |
| 0309548 | 23.75 KiB | 994.74 KiB | 970.99 KiB |
| 5cfc768 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| 664c060 | 23.74 KiB | 977.41 KiB | 953.67 KiB |
Previous results on branch: v9Decodable
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4463b8f | 1222.04 ms | 1252.11 ms | 30.07 ms |
| 887292b | 1237.00 ms | 1269.51 ms | 32.51 ms |
| 8142fa1 | 1236.86 ms | 1269.24 ms | 32.38 ms |
| e55704e | 1224.78 ms | 1255.50 ms | 30.72 ms |
| 69ea418 | 1216.50 ms | 1255.47 ms | 38.97 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4463b8f | 23.75 KiB | 986.67 KiB | 962.92 KiB |
| 887292b | 23.75 KiB | 991.17 KiB | 967.43 KiB |
| 8142fa1 | 23.75 KiB | 991.24 KiB | 967.50 KiB |
| e55704e | 23.75 KiB | 991.23 KiB | 967.48 KiB |
| 69ea418 | 23.75 KiB | 991.31 KiB | 967.57 KiB |
c0e1099 to
4db48e2
Compare
4db48e2 to
6647ea3
Compare
6647ea3 to
049dca3
Compare
049dca3 to
37e9985
Compare
37e9985 to
9ff9f90
Compare
9ff9f90 to
eb4aa9b
Compare
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Removes V9 checks for deprecated segment property and deprecated TraceContext initializers
#skip-changelog
Closes #6349, #4093