Skip to content

Conversation

@philipphofmann
Copy link
Member

📜 Description

Remove deprecated SentryUser.segment, SentryTraceContext.userSegment and SentryBaggage.userSegment

💡 Motivation and Context

Fixes GH-4093

💚 How did you test it?

Unit tests still green

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Remove deprecated SentryUser.segment, SentryTraceContext.userSegment
and SentryBaggage.userSegment

Fixes GH-4093
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.956%. Comparing base (fe83264) to head (1fb6356).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6505       +/-   ##
=============================================
- Coverage   86.996%   86.956%   -0.041%     
=============================================
  Files          452       452               
  Lines        37691     37581      -110     
  Branches     17488     17465       -23     
=============================================
- Hits         32790     32679      -111     
- Misses        4854      4857        +3     
+ Partials        47        45        -2     
Files with missing lines Coverage Δ
Sources/Sentry/SentryBaggage.m 100.000% <ø> (ø)
Sources/Sentry/SentryClient.m 99.312% <ø> (-0.010%) ⬇️
Sources/Sentry/SentryNetworkTracker.m 99.725% <ø> (-0.008%) ⬇️
Sources/Sentry/SentryTraceContext.m 96.946% <ø> (+0.992%) ⬆️
Sources/Sentry/SentryUser.m 95.488% <ø> (-0.919%) ⬇️
...ces/Swift/Protocol/Codable/SentryUserCodable.swift 100.000% <ø> (ø)

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe83264...1fb6356. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1205.12 ms 1252.66 ms 47.54 ms
Size 23.75 KiB 1.00 MiB 1005.53 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5c5648e 1234.44 ms 1253.79 ms 19.35 ms
fb48c9a 1232.49 ms 1266.27 ms 33.78 ms
d72784d 1214.31 ms 1241.35 ms 27.04 ms
7af87c1 1229.31 ms 1253.84 ms 24.53 ms
029a804 1219.65 ms 1241.96 ms 22.30 ms
139db8b 1231.50 ms 1258.19 ms 26.69 ms
7f4bf81 1241.73 ms 1270.66 ms 28.93 ms
83bb978 1238.33 ms 1260.04 ms 21.71 ms
42cfd79 1222.13 ms 1244.23 ms 22.10 ms
aac24ac 1225.94 ms 1256.38 ms 30.45 ms

App size

Revision Plain With Sentry Diff
5c5648e 23.75 KiB 879.60 KiB 855.86 KiB
fb48c9a 23.75 KiB 1006.34 KiB 982.59 KiB
d72784d 23.75 KiB 988.01 KiB 964.27 KiB
7af87c1 23.75 KiB 933.34 KiB 909.59 KiB
029a804 23.75 KiB 928.11 KiB 904.36 KiB
139db8b 23.75 KiB 920.64 KiB 896.89 KiB
7f4bf81 23.75 KiB 919.70 KiB 895.95 KiB
83bb978 23.75 KiB 920.64 KiB 896.89 KiB
42cfd79 23.75 KiB 880.20 KiB 856.45 KiB
aac24ac 23.75 KiB 1019.17 KiB 995.42 KiB

Previous results on branch: fix/remove-user-segment

Startup times

Revision Plain With Sentry Diff
3bb2fb7 1194.56 ms 1221.24 ms 26.68 ms

App size

Revision Plain With Sentry Diff
3bb2fb7 23.75 KiB 1.00 MiB 1005.53 KiB

@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryNetworkTracker.m

@philipphofmann
Copy link
Member Author

Duplicate of #6348. We can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove SentryUser.segment

1 participant