Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training for the bioconductor-scp tool #5709

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

KristinaGomoryova
Copy link

This is the PR for the Galaxy training for bioconductor-scp tool, which allows the analysis of single-cell proteomics data. The input dataset (corresponding to input for the scp vignette) is on Zenodo; the workflow comprises only this one tool. Setting individual parameters is described extensively.

TODO: sort out how to refer the Group tool (which is not on the ToolShed, related issue here).

@pavanvidem
Copy link
Member

@KristinaGomoryova ready to review?

@pavanvidem
Copy link
Member

There is also a single-cell topic. We currently have tutorials around scRNA-seq and scATAC-seq analysis in that topic. Do you think this tuitorial fits better there covering an additional modality in single-cell?

@pavanvidem
Copy link
Member

@shiltemann is there a way to symlink this tutorial also in the single-cell topic?

@nomadscientist
Copy link
Collaborator

How cool! This is so exciting!

hechth
hechth previously approved these changes Jan 29, 2025
topics/proteomics/tutorials/bioconductor-scp/tutorial.md Outdated Show resolved Hide resolved
topics/proteomics/tutorials/bioconductor-scp/tutorial.md Outdated Show resolved Hide resolved
topics/proteomics/tutorials/bioconductor-scp/tutorial.md Outdated Show resolved Hide resolved
topics/proteomics/tutorials/bioconductor-scp/tutorial.md Outdated Show resolved Hide resolved
topics/proteomics/tutorials/bioconductor-scp/tutorial.md Outdated Show resolved Hide resolved
topics/proteomics/tutorials/bioconductor-scp/tutorial.md Outdated Show resolved Hide resolved
topics/proteomics/tutorials/bioconductor-scp/tutorial.md Outdated Show resolved Hide resolved
topics/proteomics/tutorials/bioconductor-scp/tutorial.md Outdated Show resolved Hide resolved
topics/proteomics/tutorials/bioconductor-scp/tutorial.md Outdated Show resolved Hide resolved
@hechth
Copy link
Contributor

hechth commented Jan 29, 2025

Thanks @KristinaGomoryova for the training and @pavanvidem for the review!

@PratikDJagtap or @supernord do you know somebody else who could maybe also review this?

@KristinaGomoryova
Copy link
Author

@pavanvidem

@KristinaGomoryova ready to review?

Yes please, will be happy for feedback! :)

@pavanvidem
Copy link
Member

@KristinaGomoryova @hechth for me it is a bit confusing to see multiple hands-on boxes for a single tool run. It would be nice to have them as something like params box at each step and a final hands-on box with all the params together. For example, when testing, I clicked on the Run Tool button as soon as I filled first Hands-on box because this is the normal procedure.

At least, there should be a warning box at the end of the first hands-on indicating not to run the tool and more parameters need to be set before running.

@hechth
Copy link
Contributor

hechth commented Feb 3, 2025

@pavanvidem could you provide an example of what you mean?

@pavanvidem
Copy link
Member

image

I mean some warning box like this after the first scp hands-on step would help. While I was testing the workflow, I pressed the "Run Tool" after the first hands-on and obviously got an error.

Copy link
Member

@pavanvidem pavanvidem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clear and easy explanations! Great work!

Some insights into the input data and explanations of the output/plots would be nice.

topics/proteomics/tutorials/bioconductor-scp/tutorial.md Outdated Show resolved Hide resolved
topics/proteomics/tutorials/bioconductor-scp/tutorial.md Outdated Show resolved Hide resolved
topics/proteomics/tutorials/bioconductor-scp/tutorial.md Outdated Show resolved Hide resolved
topics/proteomics/tutorials/bioconductor-scp/tutorial.md Outdated Show resolved Hide resolved
topics/proteomics/tutorials/bioconductor-scp/tutorial.md Outdated Show resolved Hide resolved
## Data export

In the end of the workflow, several datasets are exported. By default, a log transformed, normalized, imputed and batch-corrected data on the protein level are provided. Additionally, it is possible to export also intermediate results, meaning peptides, normalized peptides, log transformed peptides, proteins, normalized proteins and imputed proteins. Also, it is possible to export the scp object as an Rdata object, which can be further loaded into the R environment using the R load() function, and the Rscript to reproduce the analysis outside of Galaxy. Both plots and intermediate results will be provided as collections.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a bit about the results and those beautiful plots :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed here :) 88a3735

@hechth
Copy link
Contributor

hechth commented Feb 4, 2025

thanks @pavanvidem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants