-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update funannotate #6774
base: main
Are you sure you want to change the base?
Update funannotate #6774
Conversation
- add homepage_url - fix branch
since value is yyyy-mm-dd always the oldest entry will be the first, i.e. the default
for reproducibility. we could also make this an extra tool.
from a funannotate DB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove --parameters from predict (see also TODO comment in outputs)
Did I miss the todos?
@abretaud can you please look at this one as well.
#else | ||
--database '$database.fields.path' | ||
#end if | ||
--database "$db_path" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--database "$db_path" | |
--database '$db_path' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can not use single quotes here, since the shell expansion (of '$(pwd)/hacked_database')
does not work otherwise.
#if $parameters: | ||
--parameters '${parameters}' | ||
#end if | ||
## #if $parameters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameters would only be useful if we would create such a parameter file. But the corresponding output (abinitio
) is commented out.
Co-authored-by: Björn Grüning <[email protected]>
data manager(s):
funannotate setup
tools:
funannotate database
in all tools using a DB .. then there is some detailed info on the used DB on stdout (could also be a separate tool?)--parameters
from predict (see also TODO comment in outputs)and some more but minor changes.
FOR CONTRIBUTOR: