Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update funannotate #6774

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Feb 17, 2025

data manager(s):

  • removes the manual download of additional busco outgroups as added here Funannotate data manager: add busco/orthodb10 #4182. As far as I can see this is now done in the funannotate setup
  • adds a new data manager (and corresponding data table) that generates the options for the selects. Having a fixed sets of options only works for one download (probably fine for the one currently in CVMFS).
    • it should be possible to run the new data manager also on old reference data.

tools:

  • adds outgroup parameter in compare
  • call funannotate database in all tools using a DB .. then there is some detailed info on the used DB on stdout (could also be a separate tool?)
  • remove --parameters from predict (see also TODO comment in outputs)

and some more but minor changes.

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@bernt-matthias bernt-matthias marked this pull request as draft February 17, 2025 20:27
bernt-matthias added a commit to Helmholtz-UFZ/ufz-galaxy-tools that referenced this pull request Feb 18, 2025
- add homepage_url
- fix branch
since value is yyyy-mm-dd always the oldest entry will be the first, i.e. the default
for reproducibility. we could also make this an extra tool.
@bernt-matthias bernt-matthias changed the title Bump and simplify funannotate datamanager Update funannotate Feb 19, 2025
@bernt-matthias bernt-matthias marked this pull request as ready for review February 20, 2025 21:31
@bgruening bgruening requested a review from abretaud February 21, 2025 21:25
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove --parameters from predict (see also TODO comment in outputs)

Did I miss the todos?

@abretaud can you please look at this one as well.

#else
--database '$database.fields.path'
#end if
--database "$db_path"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--database "$db_path"
--database '$db_path'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can not use single quotes here, since the shell expansion (of '$(pwd)/hacked_database') does not work otherwise.

#if $parameters:
--parameters '${parameters}'
#end if
## #if $parameters:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameters would only be useful if we would create such a parameter file. But the corresponding output (abinitio) is commented out.

Co-authored-by: Björn Grüning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants