feat: add number formatting to numeric columns (#511) #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds number formatting to numeric columns in the GA2 organism genomes table to improve readability by displaying numbers with locale-appropriate thousand separators (e.g., 1,000,000 instead of 1000000).
- Imports the
formatNumberutility function from common viewModelBuilders - Applies number formatting to LENGTH, SCAFFOLD_COUNT, SCAFFOLD_N50, and SCAFFOLD_L50 columns using cell renderers
Comments suppressed due to low confidence (1)
app/viewModelBuilders/catalog/ga2/viewModelBuilders.ts:125
- The CHROMOSOMES column (lines 124-125) should also use
formatNumberfor consistency with the other numeric columns (LENGTH, SCAFFOLD_COUNT, SCAFFOLD_N50, SCAFFOLD_L50). The corresponding column in BRC catalog usesbuildChromosomeswhich internally callsformatNumber. Add:cell: ({ getValue }) => formatNumber(getValue()),after line 124.
accessorKey: GA2_CATEGORY_KEY.CHROMOSOMES,
header: GA2_CATEGORY_LABEL.CHROMOSOMES,
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frano-m
force-pushed
the
fran/511-number-format
branch
from
1070e78 to
7b45583
Compare
MillenniumFalconMechanic
approved these changes
Nov 4, 2025
Contributor
MillenniumFalconMechanic
left a comment
MillenniumFalconMechanic
left a comment
There was a problem hiding this comment.
LGTM, thanks F!
MillenniumFalconMechanic
force-pushed
the
fran/511-number-format
branch
from
7b45583 to
294f08e
Compare
github-project-automation
bot
moved this from Ready for Review
to Done
in BRC development tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #511.
This pull request updates the genome table columns in the GA2 catalog to improve the display of numeric data. The main change is the addition of number formatting for several columns, ensuring that values like length, scaffold count, scaffold N50, and scaffold L50 are presented in a more readable format.
Enhancements to table column rendering:
formatNumberfromcommon/viewModelBuildersto enable consistent number formatting in the table columns.buildOrganismGenomesTableColumnsfunction so that theLENGTH,SCAFFOLD_COUNT,SCAFFOLD_N50, andSCAFFOLD_L50columns now useformatNumberto format their cell values.