feat: add number formatting to numeric columns (#511)

frano-m · MillenniumFalconMechanic · commit 294f08ee780e · 2025-11-04T10:05:12.000-08:00
diff --git a/app/viewModelBuilders/catalog/ga2/viewModelBuilders.ts b/app/viewModelBuilders/catalog/ga2/viewModelBuilders.ts
@@ -17,6 +17,7 @@ import {
   buildAnalyzeGenome,
   buildGenomeTaxonomicLevelStrain,
   buildIsRef,
+  formatNumber,
 } from "../brc-analytics-catalog/common/viewModelBuilders";
 
 /**
@@ -125,18 +126,22 @@ function buildOrganismGenomesTableColumns(): ColumnDef<GA2AssemblyEntity>[] {
     },
     {
       accessorKey: GA2_CATEGORY_KEY.LENGTH,
+      cell: ({ getValue }) => formatNumber(getValue()),
       header: GA2_CATEGORY_LABEL.LENGTH,
     },
     {
       accessorKey: GA2_CATEGORY_KEY.SCAFFOLD_COUNT,
+      cell: ({ getValue }) => formatNumber(getValue()),
       header: GA2_CATEGORY_LABEL.SCAFFOLD_COUNT,
     },
     {
       accessorKey: GA2_CATEGORY_KEY.SCAFFOLD_N50,
+      cell: ({ getValue }) => formatNumber(getValue()),
       header: GA2_CATEGORY_LABEL.SCAFFOLD_N50,
     },
     {
       accessorKey: GA2_CATEGORY_KEY.SCAFFOLD_L50,
+      cell: ({ getValue }) => formatNumber(getValue()),
       header: GA2_CATEGORY_LABEL.SCAFFOLD_L50,
     },
     {

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ import {`
`17`	`17`	`buildAnalyzeGenome,`
`18`	`18`	`buildGenomeTaxonomicLevelStrain,`
`19`	`19`	`buildIsRef,`
	`20`	`+ formatNumber,`
`20`	`21`	`} from "../brc-analytics-catalog/common/viewModelBuilders";`
`21`	`22`
`22`	`23`	`/**`
`@@ -125,18 +126,22 @@ function buildOrganismGenomesTableColumns(): ColumnDef<GA2AssemblyEntity>[] {`
`125`	`126`	`},`
`126`	`127`	`{`
`127`	`128`	`accessorKey: GA2_CATEGORY_KEY.LENGTH,`
	`129`	`+ cell: ({ getValue }) => formatNumber(getValue()),`
`128`	`130`	`header: GA2_CATEGORY_LABEL.LENGTH,`
`129`	`131`	`},`
`130`	`132`	`{`
`131`	`133`	`accessorKey: GA2_CATEGORY_KEY.SCAFFOLD_COUNT,`
	`134`	`+ cell: ({ getValue }) => formatNumber(getValue()),`
`132`	`135`	`header: GA2_CATEGORY_LABEL.SCAFFOLD_COUNT,`
`133`	`136`	`},`
`134`	`137`	`{`
`135`	`138`	`accessorKey: GA2_CATEGORY_KEY.SCAFFOLD_N50,`
	`139`	`+ cell: ({ getValue }) => formatNumber(getValue()),`
`136`	`140`	`header: GA2_CATEGORY_LABEL.SCAFFOLD_N50,`
`137`	`141`	`},`
`138`	`142`	`{`
`139`	`143`	`accessorKey: GA2_CATEGORY_KEY.SCAFFOLD_L50,`
	`144`	`+ cell: ({ getValue }) => formatNumber(getValue()),`
`140`	`145`	`header: GA2_CATEGORY_LABEL.SCAFFOLD_L50,`
`141`	`146`	`},`
`142`	`147`	`{`