Skip to content

Conversation

crStiv
Copy link
Contributor

@crStiv crStiv commented Jul 19, 2025

Removed redundant warn!/error! calls to reduce log noise and improve clarity

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense, but there's no need to put changes as docs

@crStiv
Copy link
Contributor Author

crStiv commented Jul 26, 2025

this makes sense, but there's no need to put changes as docs

tnx for the review, does it make sense now?

@crStiv crStiv requested a review from mattsse July 26, 2025 15:14
@crStiv crStiv requested a review from mattsse July 27, 2025 15:51
@zerosnacks zerosnacks dismissed a stale review August 5, 2025 16:44
@crStiv crStiv requested a review from zerosnacks August 5, 2025 18:29
DaniPopes
DaniPopes previously approved these changes Aug 12, 2025
@DaniPopes DaniPopes enabled auto-merge (squash) August 12, 2025 09:46
@DaniPopes DaniPopes merged commit f50769f into foundry-rs:master Aug 14, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants