refactor(verify): remove redundant logging in Etherscan provider (#11048)

* Update mod.rs

* Update mod.rs

* Update mod.rs

* Update crates/verify/src/etherscan/mod.rs

Co-authored-by: zerosnacks <[email protected]>

* Update crates/verify/src/etherscan/mod.rs

Co-authored-by: zerosnacks <[email protected]>

* fmt

---------

Co-authored-by: zerosnacks <[email protected]>
Co-authored-by: DaniPopes <[email protected]>

Author: 3 people

crates/verify/src/etherscan/mod.rs

@@ -92,7 +92,6 @@ impl VerificationProvider for EtherscanVerificationProvider {
                     .wrap_err_with(|| {
                         // valid json
                         let args = serde_json::to_string(&verify_args).unwrap();
-                        error!(?args, "Failed to submit verification");
                         format!("Failed to submit contract verification, payload:\n{args}")
                     })?;
 
@@ -110,16 +109,16 @@ impl VerificationProvider for EtherscanVerificationProvider {
                         || resp.result.starts_with("The address is not a smart contract")
                     {
                         warn!("{}", resp.result);
-                        return Err(eyre!("Could not detect the deployment."));
+                        return Err(eyre!("Could not detect deployment: {}", resp.result));
                     }
 
-                    warn!("Failed verify submission: {:?}", resp);
                     sh_err!(
                         "Encountered an error verifying this contract:\nResponse: `{}`\nDetails:
                         `{}`",
                         resp.message,
                         resp.result
                     )?;
+                    warn!("Failed verify submission: {:?}", resp);
                     std::process::exit(1);
                 }
 
@@ -186,7 +185,11 @@ impl VerificationProvider for EtherscanVerificationProvider {
                 }
 
                 if resp.status == "0" {
-                    return Err(RetryError::Break(eyre!("Contract failed to verify.")));
+                    return Err(RetryError::Break(eyre!(
+                        "Contract verification failed:\nStatus: `{}`\nResult: `{}`",
+                        resp.status,
+                        resp.result
+                    )));
                 }
 
                 if resp.result == "Pass - Verified" {