Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore rounded corners #4306

Closed
iamareebjamal opened this issue Apr 9, 2020 · 28 comments
Closed

Restore rounded corners #4306

iamareebjamal opened this issue Apr 9, 2020 · 28 comments

Comments

@iamareebjamal
Copy link
Member

iamareebjamal commented Apr 9, 2020

fossasia/open-event-theme@0206df7

There's a lot of research on why rounded corners are better in UI. Flat design with square corners makes Open Event look unfinished and drab. Not to say that a lack of theme color is not helping. Hence, I think rounded corners should be restored. Except Microsoft's UI, which is still not a golden standard, I have seen no site which uses sharp corners.

https://designmodo.com/rounded-corners/
https://uxmovement.com/thinking/why-rounded-corners-are-easier-on-the-eyes/
https://uxplanet.org/rounded-or-sharp-corner-buttons-def3977ed7c4
https://medium.com/@gotoxplore/rounded-or-square-corners-for-better-user-experience-28af389bf979

First button does not even look like a button, and looks unfinished

If someone has strong opinions on this, let's discuss

PS: Even Microsoft: microsoft/microsoft-ui-xaml#524 (comment)
https://github.com/mrlacey/microsoft-ui-xaml-specs/blob/RoundedCornerVisualizations/active/RoundedCorner/ImageFiles/index.md

@snitin315
Copy link
Member

+1 for round corners. I will work on this one.

@iamareebjamal
Copy link
Member Author

Any updates @snitin315 ?

@snitin315
Copy link
Member

i will make PR today.

@kushthedude
Copy link
Member

Updating to semantic UI 3.0.4 should make corners round. Deploy preview of #3872 had rounded corners for buttons.

@iamareebjamal
Copy link
Member Author

That's because it breaks the project, not fixes the rounded corner thing. Proper fix is to revert this commit fossasia/open-event-theme@0206df7

@adkrgu
Copy link

adkrgu commented May 6, 2020

As I see this issue is still open and is not assigned to anyone, can I work on this issue?

@iamareebjamal
Copy link
Member Author

Yes

@Deeksha2501
Copy link

Yes , rounded corners are better
I want to work on this issue

@iamareebjamal
Copy link
Member Author

@AdityaKG-169 asked first, so maybe if he can't do it, you may take it up

@Deeksha2501
Copy link

@iamareebjamal 0k :)

@Deeksha2501
Copy link

@AdityaKG-169 Any updates?

@dsnehasish74
Copy link
Member

dsnehasish74 commented May 7, 2020

I am a beginer . can I work on it???? I want to do my first contribution

@iamareebjamal
Copy link
Member Author

@Deeksha2501 You can work on the issue

@Deeksha2501
Copy link

Thank you! I will start doing it!!!

@naman360
Copy link
Contributor

Can I work on this issue?

@iamareebjamal
Copy link
Member Author

@Deeksha2501 Any progress?

@naman360
Copy link
Contributor

fossasia/open-event-theme#11
Where are the changes need to be done then?

@iamareebjamal
Copy link
Member Author

Use 0.2.1-rounded version of @open-event/theme

@icoderharshit
Copy link

has this issue been resolved ? or can I work upon it, making it look more appealing.

@Deeksha2501
Copy link

@iamareebjamal I am getting an error,
I was not able to run the code in my local machinery , maybe some version mismatch

@naman360
Copy link
Contributor

@iamareebjamal so should I start working now on this issue?

@iamareebjamal
Copy link
Member Author

Yes

@naman360
Copy link
Contributor

Does site.overrides file needs to be changed?

@iamareebjamal
Copy link
Member Author

No

@iamareebjamal
Copy link
Member Author

#4306 (comment)

@naman360
Copy link
Contributor

Do I need to gulp build too?

@iamareebjamal
Copy link
Member Author

#4306 (comment)

@naman360
Copy link
Contributor

Okay creating a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants