-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore rounded corners #4306
Comments
+1 for round corners. I will work on this one. |
Any updates @snitin315 ? |
i will make PR today. |
Updating to semantic UI 3.0.4 should make corners round. Deploy preview of #3872 had rounded corners for buttons. |
That's because it breaks the project, not fixes the rounded corner thing. Proper fix is to revert this commit fossasia/open-event-theme@0206df7 |
As I see this issue is still open and is not assigned to anyone, can I work on this issue? |
Yes |
Yes , rounded corners are better |
@AdityaKG-169 asked first, so maybe if he can't do it, you may take it up |
@iamareebjamal 0k :) |
@AdityaKG-169 Any updates? |
I am a beginer . can I work on it???? I want to do my first contribution |
@Deeksha2501 You can work on the issue |
Thank you! I will start doing it!!! |
Can I work on this issue? |
@Deeksha2501 Any progress? |
fossasia/open-event-theme#11 |
Use |
has this issue been resolved ? or can I work upon it, making it look more appealing. |
@iamareebjamal I am getting an error, |
@iamareebjamal so should I start working now on this issue? |
Yes |
Does |
No |
Do I need to |
Okay creating a PR |
fossasia/open-event-theme@0206df7
There's a lot of research on why rounded corners are better in UI. Flat design with square corners makes Open Event look unfinished and drab. Not to say that a lack of theme color is not helping. Hence, I think rounded corners should be restored. Except Microsoft's UI, which is still not a golden standard, I have seen no site which uses sharp corners.
https://designmodo.com/rounded-corners/
https://uxmovement.com/thinking/why-rounded-corners-are-easier-on-the-eyes/
https://uxplanet.org/rounded-or-sharp-corner-buttons-def3977ed7c4
https://medium.com/@gotoxplore/rounded-or-square-corners-for-better-user-experience-28af389bf979
First button does not even look like a button, and looks unfinished
If someone has strong opinions on this, let's discuss
PS: Even Microsoft: microsoft/microsoft-ui-xaml#524 (comment)
https://github.com/mrlacey/microsoft-ui-xaml-specs/blob/RoundedCornerVisualizations/active/RoundedCorner/ImageFiles/index.md
The text was updated successfully, but these errors were encountered: