Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: Rounded corners #4375

Closed
wants to merge 8 commits into from
Closed

enh: Rounded corners #4375

wants to merge 8 commits into from

Conversation

naman360
Copy link
Contributor

@naman360 naman360 commented May 11, 2020

Fixes #4306

Short description of what this resolves:

Adds rounded corners.

Changes proposed in this pull request:

  • Change version of @open-event/theme from 0.2.1 to 0.2.1-rounded

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented May 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/6o7zj41fq
✅ Preview: https://open-event-frontend-git-fork-naman360-development.eventyay.now.sh

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #4375 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4375   +/-   ##
============================================
  Coverage        22.78%   22.78%           
============================================
  Files              468      468           
  Lines             4932     4932           
  Branches             5        5           
============================================
  Hits              1124     1124           
  Misses            3806     3806           
  Partials             2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c91185...3930da7. Read the comment docs.

@iamareebjamal
Copy link
Member

Unneeded commits. Never create a PR from development/master branch

@naman360
Copy link
Contributor Author

ok so what should I do now?

@snitin315
Copy link
Member

Rebase correctly.

@iamareebjamal
Copy link
Member

Close the PR and make it from a new branch

@naman360
Copy link
Contributor Author

Okay sure.

@naman360 naman360 closed this May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore rounded corners
3 participants