-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: Rounded corners #4377
enh: Rounded corners #4377
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/d1afvb0rj |
Codecov Report
@@ Coverage Diff @@
## development #4377 +/- ##
============================================
Coverage 22.89% 22.89%
============================================
Files 468 468
Lines 4941 4941
Branches 5 5
============================================
Hits 1131 1131
Misses 3808 3808
Partials 2 2 Continue to review full report at Codecov.
|
Okay will look at it. |
@naman360 Status? |
Working on it. |
@iamareebjamal Can you please help me with the codebase of |
No change needs to be done in theme, everything needs to be changed in this project only |
Still cannot find related files. Want some help. |
Find where they are located. It is a part of debugging process, if I tell you exactly what to do, then what's the difference in me solving the issue and you just following the instructions, that's spoonfeeding |
Okay cool. |
There is absolutely no need to change CSS, all you need to change are classes in HTML |
So, should I create new classes and then add the styling? |
No need of adding new classes, read Semantic UI docs |
okay |
fixed |
Fixes #4306
Short description of what this resolves:
Adds rounded corners
Changes proposed in this pull request:
@open-event/theme
version from0.2.1
to0.2.1-rounded
Checklist
development
branch.