Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: Rounded corners #4377

Closed
wants to merge 6 commits into from
Closed

enh: Rounded corners #4377

wants to merge 6 commits into from

Conversation

naman360
Copy link
Contributor

Fixes #4306

Short description of what this resolves:

Adds rounded corners

Changes proposed in this pull request:

  • Changed @open-event/theme version from 0.2.1 to 0.2.1-rounded

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Sorry, something went wrong.

@vercel
Copy link

vercel bot commented May 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/d1afvb0rj
✅ Preview: https://open-event-frontend-git-fork-naman360-enhancement.eventyay.now.sh

@iamareebjamal
Copy link
Member

Middle boxes should not be rounded

image

There should not be rounded edges between password and view icon

image

Look through other places of UI as well

@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #4377 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4377   +/-   ##
============================================
  Coverage        22.89%   22.89%           
============================================
  Files              468      468           
  Lines             4941     4941           
  Branches             5        5           
============================================
  Hits              1131     1131           
  Misses            3808     3808           
  Partials             2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad09367...eb414d9. Read the comment docs.

@naman360
Copy link
Contributor Author

Okay will look at it.

@iamareebjamal
Copy link
Member

@naman360 Status?

@naman360
Copy link
Contributor Author

Working on it.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@naman360
Copy link
Contributor Author

@iamareebjamal Can you please help me with the codebase of @open-event/theme I am unable to figure out where to do changes.

@iamareebjamal
Copy link
Member

No change needs to be done in theme, everything needs to be changed in this project only

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@naman360
Copy link
Contributor Author

Still cannot find related files. Want some help.

@iamareebjamal
Copy link
Member

iamareebjamal commented May 19, 2020

Middle boxes should not be rounded

image

There should not be rounded edges between password and view icon

image

Look through other places of UI as well

Find where they are located. It is a part of debugging process, if I tell you exactly what to do, then what's the difference in me solving the issue and you just following the instructions, that's spoonfeeding

@naman360
Copy link
Contributor Author

Okay cool.

@vercel vercel bot temporarily deployed to Preview May 20, 2020 06:02 Inactive

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@iamareebjamal
Copy link
Member

There is absolutely no need to change CSS, all you need to change are classes in HTML

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@naman360
Copy link
Contributor Author

So, should I create new classes and then add the styling?

@iamareebjamal
Copy link
Member

No need of adding new classes, read Semantic UI docs

@naman360
Copy link
Contributor Author

okay

@iamareebjamal
Copy link
Member

fixed

@naman360 naman360 deleted the enhancement branch May 23, 2020 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore rounded corners
2 participants