fix build failure with nagfor because of "isnan" (issue #159) #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ieee_arithmetic module is added and isnan is replaced to ieee_is_nan.
milancurcic
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
This PR is straightforward and tests pass. Will merge. Thanks @sakamoti!
|
Thank you for the PR!
…On Fri, Mar 20, 2020, at 5:19 PM, Milan Curcic wrote:
Merged #160 <#160> into master.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#160 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFAWAOEUZ6DBP7QHP52ELRIP2ZHANCNFSM4LO7PTTQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ieee_arithmeticmodule is added andisnanis replaced toieee_is_nan.This fixes the issue #159.