Skip to content

Build with nagfor(7.0) is fail because of "isnan" #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sakamoti opened this issue Mar 18, 2020 · 2 comments
Closed

Build with nagfor(7.0) is fail because of "isnan" #159

sakamoti opened this issue Mar 18, 2020 · 2 comments

Comments

@sakamoti
Copy link
Contributor

There are many isnan functions are used in test_mean.f90, test_moment.f90, test_var.f90 and test_varn.f90 files. But isnan is not a fortran standard. So, NAG fortran compiler (nagfor) fail to build these files. What about using ieee_is_nan instead of isnan?

@jvdp1
Copy link
Member

jvdp1 commented Mar 18, 2020

Thank you for testing stdlib.
ieee_is_nan could be used indeed. ieee_arithmetic is already used to generate NaN in mean(), moment(), and var() functions.

If you have time, could you modify the tests and submit a PR, please?

There has been several discussions around NaN and its implementation (e.g., #147). A more general solution is needed. Meanwhile, using ieee_is_nan should be fine, and a better solution than using compiler-dependent is_nan.

milancurcic added a commit that referenced this issue Mar 20, 2020
fix build failure with nagfor because of "isnan" (issue #159)
@sakamoti
Copy link
Contributor Author

Thank you for merging pull request #160 . Close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants